Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366522

Summary:	[Compatibility] Failures in MultiEditorTestSuite
Product:	[Eclipse Project] Platform	Reporter:	Remy Suen <remy.suen>
Component:	UI	Assignee:	Remy Suen <remy.suen>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel, rolf.theunissen, sptaszkiewicz
Version:	4.1
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:
Bug Blocks:	366451, 381873

Description Remy Suen

2011-12-13 08:17:22 EST

MultiEditorTestSuite has 1e/3f out of 5 tests. They all look like valid tests to me.

Comment 1 Remy Suen

2011-12-13 08:32:52 EST

Fixed MultiEditorTest's testDirty method. That's one failure down.

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=6fc06f3c8835769f6a4db0d2b8682bb79b6a5fd3

Comment 2 Remy Suen

2011-12-13 09:35:11 EST

Implemented support for AbstractMultiEditors. AbstractMultiEditorTest's testBug317102() is now passing.

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9802ad7f52c7db2378f3e9c58d4e6606869b08e9

Comment 3 Remy Suen

2011-12-13 10:55:59 EST

While comparing the behaviour across the streams, it feels to me as though TiledEditor or MultiEditor is broken on 3.x.

Comment 4 Szymon Ptaszkiewicz

2013-04-29 09:11:42 EDT

(In reply to comment #3)
> While comparing the behaviour across the streams, it feels to me as though
> TiledEditor or MultiEditor is broken on 3.x.

Yes, it looks that there might be something wrong with it even on 3.x. I just came across it when working on bug 396528. MultiEditorTest.testOpenTestFile() is not very strict when it comes to verifying the number and order in which TiledEditor methods are called.

Comment 5 Lars Vogel

2020-03-31 11:19:29 EDT

After 7 years of inactivity I think this can be closed

Comment 6 Rolf Theunissen

2020-03-31 11:23:43 EDT

(In reply to Lars Vogel from comment #5)
> After 7 years of inactivity I think this can be closed

This would also mean that E4 will never get MultiEditor support, as currently the implementation is broken.
Should the MultiEditor support be removed from Eclipse?

Comment 7 Lars Vogel

2020-03-31 11:30:05 EDT

(In reply to Rolf Theunissen from comment #6)
> (In reply to Lars Vogel from comment #5)
> > After 7 years of inactivity I think this can be closed
> 
> This would also mean that E4 will never get MultiEditor support, as
> currently the implementation is broken.
> Should the MultiEditor support be removed from Eclipse?

No, this just means that I guessed that nobody plans to work on MultiEditorTestSuite. If you disagree or plan to work on this topic, please reopen.