Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366449

Summary: [Compatibility] No hook for event idle loop yet
Product: [Eclipse Project] Platform Reporter: Paul Webster <pwebster>
Component: UIAssignee: Paul Webster <pwebster>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: dean.t.roberts, ob1.eclipse, remy.suen
Version: 4.2   
Target Milestone: 4.2 M5   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on:    
Bug Blocks: 366451, 381873    
Attachments:
Description Flags
Allow event idle advisor v01 none

Description Paul Webster CLA 2011-12-12 14:22:51 EST
org.eclipse.ui.parts.tests.PartsReferencesTestSuite depends on implementing org.eclipse.ui.application.WorkbenchAdvisor.eventLoopIdle(Display) but in Eclipse 4, we have no hook for the event idle loop yet.

Without this, all of its tests hang.

PW
Comment 1 Paul Webster CLA 2011-12-14 14:52:00 EST
Created attachment 208401 [details]
Allow event idle advisor v01

The part rendering engine takes "advice" from the IEventLoopAdvisor.

PW
Comment 2 Paul Webster CLA 2011-12-15 09:56:44 EST
This patches allows PartsReferencesTestSuite to finish.  It takes 2626 seconds to run.

This is compared to 26 seconds.

PW
Comment 3 Paul Webster CLA 2011-12-15 12:09:39 EST
Switched around the runOnce variable and released.

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=086d5af83b661709b371be311e75f2cc341a6c56

PW
Comment 4 Paul Webster CLA 2012-01-24 13:47:39 EST
In I20120123-2200
PW