Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366317

Summary: jgit log crashes in the presence of notes when no argument are passed
Product: [Technology] JGit Reporter: Robin Rosenberg <robin.rosenberg>
Component: JGitAssignee: Project Inbox <jgit.core-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: sop
Version: 1.2   
Target Milestone: 2.1   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:

Description Robin Rosenberg CLA 2011-12-10 18:53:35 EST
$ jgit log
java.lang.NullPointerException
	at org.eclipse.jgit.pgm.Log.addNoteMap(Log.java:227)
	at org.eclipse.jgit.pgm.Log.run(Log.java:201)
	at org.eclipse.jgit.pgm.TextBuiltin.execute(TextBuiltin.java:148)
	at org.eclipse.jgit.pgm.Main.execute(Main.java:191)
	at org.eclipse.jgit.pgm.Main.run(Main.java:120)
	at org.eclipse.jgit.pgm.Main.main(Main.java:94)

Bisect points to 489604aaad8ef8d252bf31056db4de01e690fa0b

$ jgit log HEAD # does not crash

A reason may be that there are too many "walks" in the code, leading to confusion
about which one to use and when.
Comment 1 Robin Rosenberg CLA 2013-04-19 04:44:12 EDT
Was fixed in 2.1
Comment 2 Robin Rosenberg CLA 2013-04-19 04:44:29 EDT
.