Bug 366307

Comment 1 Brian Fitzpatrick 2012-01-06 18:10:52 EST

Ok, I'm a little confused on this one.

I can see revamping it to be a bit more like the Type Hierarchy View, with a split pane and two toolbars (as necessary). But I'm confused by what the text is referring to about "puts result related actions in the results tab." 

Is Dani referring to the popup menus on the results tree items themselves?

Along the same line of thinking, I think we could do a horizontal or vertical alignment to make the view more flexible in various perspectives - much like the Type Hierarchy view. 

On the search side, I can't see any obvious toolbar buttons to add. But on the results side, we could probably add buttons for "Open" and "Add to Search Favorites" and "Properties"

As an aside - what property sheet is supposed to be opened when you click the "Manage Destinations" link in the search area? And what properties are supposed to appear on the category folder in the results when you select "Properties" in the context menu?

Comment 2 Dani Megert 2012-01-09 06:12:06 EST

(In reply to comment #0)
> The current compatibility prototype implementation puts result related actions
> in the results tab. The alternative is to place them in the very view action
> bars.
> 
> One should keep in mind that 
>  - these actions are relevant to results only
>  - the Hierarchy view also separates actions into two action bars - one for 
> the class whose hierarchy is being shown and one for the "outline" section

But there the buttons are not close to the top of the view. Those at the top are indeed local/view toolbar actions/buttons.


> Is Dani referring to the popup menus on the results tree items themselves?
This is my initial comment/feedback:
"It looks awkward that the view toolbar items are not in the view but in a
tab. This should be changed."

Comment 3 Brian Fitzpatrick 2012-01-24 13:22:04 EST

Ok, I'm still confused.

Dani, you say: "It looks awkward that the view toolbar items are not in the view but in a tab. This should be changed." But I'm not seeing any "view toolbar buttons" even in the tab.

The Search Console view has two halves - the Search parameters half and the Results half. 

On the Search parameters half there are no buttons, but there is a text hyperlink called "Manage Destinations" along with a "Search for" drop-down, a "Search in" tree list (scrollable, but doesn't expand), the hyperlink, a "Find" text field, and a "Group by" drop-down with two options - by Category or Flat List. And then a Search button.

Of these, I can see moving the "Group by" button to a toolbar on the Results side similar to the method list (right) side of the Type Hierarchy. It affects the results, not the search, so I think it belongs there anyway.

And maybe moving the hyperlink to a button on the left side (parameters side).

On the Results side of the Search Console, you get a few options on the context menu. For categories, all you see is "Properties" and for actual results in the list you see "Add to Search Favorites," "Open," and "Properties."

I can see all of these becoming buttons on the Results side toolbar as well as staying in the context menu. So now we're up to 4 buttons on the right side and one button on the left side. 

Is that what we're going for here?

Comment 4 Danail Branekov 2012-01-25 05:58:43 EST

Created attachment 210040 [details]
Buttons for the result; horizontal layout

Comment 5 Danail Branekov 2012-01-25 05:59:10 EST

Created attachment 210041 [details]
Buttons for the result; vertical layout

Comment 6 Danail Branekov 2012-01-25 05:59:22 EST

Brian, 

Dani is referring to the buttons which (might) be available to the search result. In order to see such buttons, you need to checkout the prototype branch. The branch contains a prrof-of-concept on how to integrate existing eclipse search capabilities in the search console. As this is a proof-of-concept work there might be some bugs. For example, if you start the runtime workbench with a console view already opened, you would not be able to see the "native" search providers and you will need to restart the console view
I am attaching two screenshots which demonstrate the buttons location for the files search in the horizontal and vertical layouts of the console

Regards, Danail

Comment 7 Brian Fitzpatrick 2012-01-31 16:49:51 EST

Now that I've played around a bit with the prototype branch, I can see what you guys have been talking about. :) Now pondering this from a different direction...

How do you get it to go with a vertical vs. a horizontal alignment?

Comment 8 Lars Vogel 2019-09-04 03:11:41 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it and remove the stalebug whiteboard tag. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--