Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366224

Summary: UR0003W should list the packages which overlap the system bundle exports
Product: [RT] Virgo Reporter: Glyn Normington <glyn.normington>
Component: runtimeAssignee: Glyn Normington <glyn.normington>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3    
Version: 3.0.1.RELEASE   
Target Milestone: 3.5.0.M01   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
URL: http://www.eclipse.org/forums/index.php/bm/msg/263241/1/on/0/?SQ=aea272ed0a3ce4b5db3baa54bfb4fc84
Whiteboard:
Attachments:
Description Flags
bundle-importer jar none

Description Glyn Normington CLA 2011-12-09 11:58:53 EST 
The diagnostics below don't pick out which packages are exported by the imported bundle and the system bundle. They include javax.transaction, but it's hard to see that below.

[2011-12-09 16:29:43.445] fs-watcher                   <UR0003W> Detected Import-Bundle of bundle 'org.neo4j.neo4j-osgi-bundle' version '0.1.0.SNAPSHOT' which exports packages that are exported by the system bundle: consider importing the packages explicitly. For example, use Import-Package: org.neo4j.cypher.javacompat,scala.annotation.unchecked,org.apache.lucene.util,org.neo4j.kernel.impl.persistence,org.neo4j.cypherdsl,org.apache.lucene.search.function,org.neo4j.index.impl.lucene,org.neo4j.graphdb.index,org.apache.lucene,scala.reflect.generic,org.neo4j.graphdb.traversal,scala.concurrent,scala.util.parsing.combinator.testing,org.neo4j.kernel.impl.osgi,org.apache.lucene.store,org.apache.lucene.search.payloads,org.neo4j.kernel.impl.annotations,org.neo4j.cypherdsl.result,org.neo4j.kernel.impl.transaction,scala.util.automata,org.neo4j.ext.udc,org.neo4j.kernel.impl.nioneo.store,org.neo4j.graphalgo.impl.util,scala.util.matching,scala.util.parsing.combinator,org.neo4j.jmx.impl,org.neo4j.cypher.pipes,scala.util.parsing.json,org.neo4j.cypherdsl.querydsl,org.neo4j.graphmatching.filter,org.apache.lucene.search.spans,scala.xml.dtd,org.apache.lucene.search,scala.collection,scala.text,org.neo4j.kernel.impl.util,scala.actors,org.neo4j.graphalgo.impl.path,org.neo4j.kernel.impl.traversal,scala.xml.include,scala.collection.parallel,scala.collection.script,scala.util.control,scala.xml.parsing,org.apache.lucene.queryParser,org.apache.lucene.document,org.neo4j.tooling,scala.annotation.target,org.neo4j.kernel.impl.nioneo.xa,scala.collection.parallel.immutable,org.neo4j.graphdb,org.neo4j.ext.udc.impl.osgi,scala.parallel,org.apache.lucene.collation,org.neo4j.kernel.impl.storemigration.monitoring,org.neo4j.kernel.impl,org.neo4j.cypher.pipes.matching,scala.actors.threadpool.locks,scala.util.regexp,scala.collection.parallel.mutable,scala.xml.include.sax,scala.xml.factory,org.neo4j.cypherdsl.query,scala.util.parsing.combinator.lexical,scala.util.parsing.combinator.syntactical,scala.sys.process,org.neo4j.kernel,scala.collection.interfaces,scala.xml.persistent,org.apache.lucene.index,scala.actors.threadpool,org.neo4j.index.lucene,scala.annotation,scala.concurrent.forkjoin,scala.reflect,org.neo4j.kernel.impl.storemigration,javax.transaction.xa,scala.io,scala.ref,scala.util.parsing.syntax,org.neo4j.kernel.impl.storemigration.legacystore,org.neo4j.graphdb.event,org.apache.lucene.analysis.tokenattributes,org.neo4j.cypher.pipes.aggregation,scala.compat,scala.runtime,org.neo4j.kernel.impl.transaction.xaframework,scala.util.parsing.ast,scala.util.logging,org.neo4j.helpers,scala.util.parsing.combinator.token,scala.util.parsing.input,scala.testing,scala.util.grammar,scala.collection.immutable,scala.actors.scheduler,scala,org.neo4j.graphalgo.impl.centrality,scala.util.continuations,org.neo4j.kernel.impl.cache,org.neo4j.graphmatching,scala.math,scala.util,org.neo4j.cypher.commands,scala.actors.threadpool.helpers,org.neo4j.cypherdsl.query.neo4j,org.apache.lucene.messages,org.neo4j.ext.udc.impl,org.neo4j.jmx,scala.sys,org.neo4j.cypher.parser,scala.xml,org.neo4j.kernel.impl.batchinsert,scala.actors.remote,org.neo4j.graphalgo,scala.collection.mutable,org.neo4j.helpers.collection,org.neo4j.graphalgo.impl.shortestpath,org.apache.lucene.analysis.standard,scala.xml.transform,scala.xml.pull,org.neo4j.cypher,javax.transaction,org.neo4j.kernel.impl.index,scala.collection.generic,org.neo4j.kernel.impl.core,org.apache.lucene.analysis. 

Steps to reproduce:
1. Unzip neo4j-bundle.zip from http://dl.dropbox.com/u/2487064/neo4j-bundle.zip
2. Unzip http://dl.dropbox.com/u/2487064/spring-framework-dist-3.0.6.RELEASE.zip and replace the repository/ext
Spring 3.0.5 JARs with their 3.0.6 equivalents.
3. Place the contents of the repository/usr directory in the first unzip into
Virgo's repository/usr.
4. Place the bundle neo4j-osgi-bundle-0.1-SNAPSHOT.jar from the pickup
directory in the first unzip into Virgo's repository/usr. (This avoids an
ordering issue in pickup.)
5. Place the attached neo-importer.jar into pickup.
directory in the first unzip into Virgo's pickup directory.
6. Start Virgo with bin/startup.sh -clean.
7. Observe the diagnostics appearing on the console.
Comment 1 Glyn Normington CLA 2011-12-09 12:03:18 EST 
Created attachment 208180 [details]
bundle-importer jar
Comment 2 Glyn Normington CLA 2011-12-13 11:03:13 EST 
Extended the warning message to list the packages which overlap. Importing the neo4j bundle now gives:

UR0003W> Detected Import-Bundle of bundle 'org.neo4j.neo4j-osgi-bundle' version '0.1.0.SNAPSHOT' which exports packages [javax.transaction, javax.transaction.xa] that are exported by the system bundle: consider importing the packages explicitly. For example, use Import-Package: org.neo4j.cypher.javacompat,scala.annotation.unchecked,etc.

The fix and a corresponding test is in kernel commit 6e7b22d85e70ba7b782216ab47b9fa6530ea2f26.