Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366220

Summary: [dstore] Log_To_File no longer default value for log_location in rsecomm.properties
Product: [Tools] Target Management Reporter: Onno Van den Troost <onno>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: dmcknigh
Version: 3.2.1   
Target Milestone: 3.4 M5   
Hardware: Other   
OS: other   
Whiteboard:
Bug Depends on:    
Bug Blocks: 366438    
Attachments:
Description Flags
test patch
none
updated patch to fall back to log to file rather than log to stout none

Description Onno Van den Troost CLA 2011-12-09 11:24:27 EST
We're including the latest 3.2.x OpenRSE build to pick up the resolution for some bugs we reported.

Unfortunately, other changes done to 3.2.x cause us problems. We no longer get rsecomm.log. We did find that the output now goes to stdout.
When we specify "log_location=Log_To_File" explicitly in rsecomm.properties, things work again as expected.

We rely on log_location=Log_To_File to be the default setting, and need this behavior to be restored.
Comment 1 Onno Van den Troost CLA 2011-12-09 11:25:42 EST
We think that
[351993] [dstore] not able to connect to server if .eclipse folder not available
is the root cause for the changed behavior.
Comment 2 David McKnight CLA 2011-12-09 13:07:29 EST
Onno, the default for the rsecomm.properties file in RSE 3.2.x is this:

 log_location=Log_To_File

Do you not have that set by default?
Comment 3 David McKnight CLA 2011-12-09 13:15:37 EST
Created attachment 208186 [details]
test patch

I see a potential issue in the case where rsecomm.log has not yet been created although I'm not sure this is the issue you're hitting.  Can you see if this patch makes any difference?
Comment 4 David McKnight CLA 2011-12-09 13:57:55 EST
Alright, so now I understand that you guys don't actually use rsecomm.properties.  This is something I wasn't aware of.  Right now the ServerLogger falls back to use stdout if there is an exception finding the rsecomm.properties file.  To preserve the original behaviour (for the case where there is no rsecomm.properties), I can change that back to use the file-based logging.
Comment 5 David McKnight CLA 2011-12-09 14:00:20 EST
Created attachment 208192 [details]
updated patch to fall back to log to file rather than log to stout
Comment 6 Onno Van den Troost CLA 2011-12-11 23:09:27 EST
David,

By default, when a user connects to the host, an existing rsecomm.log is wiped out and it starts again from scratch. We have a mechanism to rename rsecomm.log to rsecomm.last during logon, to preserve the last log for support purposes.

I don't know enough about the internals, but it makes sense to me that this rename happens before RSE gets its hands on it, so there is indeed no rsecomm.log as far as RSE is concerned.

Regarding rsecomm.properties. Things get messy in the single server setup when log_location is not set to Log_To_File, so we're shielding customers from shooting themselves in the foot by not providing the directive in the sample rsecomm.properties we provide. But we do have a rsecomm.properties file, used for the debug_level directive.

I hope this info still fits in your current understanding and resolution of the problem.

Onno
Comment 7 David McKnight CLA 2011-12-12 09:42:37 EST
(In reply to comment #6)
> David,
> 
> By default, when a user connects to the host, an existing rsecomm.log is wiped
> out and it starts again from scratch. We have a mechanism to rename rsecomm.log
> to rsecomm.last during logon, to preserve the last log for support purposes.
> 
> I don't know enough about the internals, but it makes sense to me that this
> rename happens before RSE gets its hands on it, so there is indeed no
> rsecomm.log as far as RSE is concerned.
> 
> Regarding rsecomm.properties. Things get messy in the single server setup when
> log_location is not set to Log_To_File, so we're shielding customers from
> shooting themselves in the foot by not providing the directive in the sample
> rsecomm.properties we provide. But we do have a rsecomm.properties file, used
> for the debug_level directive.
> 
> I hope this info still fits in your current understanding and resolution of the
> problem.
> 
> Onno

Onno, alright that helps explain things.  Assuming the patch here solves the issue, do you need this backported for RSE 3.2.x?
Comment 8 Onno Van den Troost CLA 2011-12-12 12:14:28 EST
yes, please backport to 3.2.x
Comment 9 David McKnight CLA 2011-12-13 08:55:25 EST
I've committed the change.