Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366214

Summary: [Compatibility] Add support for AbstractTrimWidgets
Product: [Eclipse Project] Platform Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Remy Suen <remy.suen>
Status: VERIFIED FIXED QA Contact: Eric Moffatt <emoffatt>
Severity: normal    
Priority: P3 CC: bhunt, emoffatt, john.camelon, Michael.Valenta, Mike_Wilson, Olivier_Thomann, pwebster, remy.suen, thatnitind
Version: 4.1   
Target Milestone: 4.2 M5   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
LegacyTrim patch v1 none

Description Remy Suen CLA 2011-12-09 10:54:43 EST 
Code was added to support IWorkbenchWidget. We need code to support the AbstractWorkbenchTrimWidget class which has a specialized fill(Composite, int, int) method.

+++ This bug was initially created as a clone of Bug #330106 +++

I installed the latest RTC into Eclipse 4.1 M3. When I started Eclipse, I noticed that our work item trim component is missing. There were no errors in the log. Eric indicated that he knew what the issue probably is.
Comment 1 Remy Suen CLA 2011-12-09 11:04:23 EST 
Created attachment 208174 [details]
LegacyTrim patch v1

Add a check to determine whether the instantiated IWorkbenchWidget is an implementation of the AbstractTrimWidget class. If it is, use its specialized fill(Composite, int, int) method instead of IWorkbenchWidget's fill(Composite) method.
Comment 2 Remy Suen CLA 2011-12-09 11:05:25 EST 
I'll get this in as soon as M4 is out.
Comment 3 Remy Suen CLA 2011-12-13 09:42:50 EST 
(In reply to comment #1)
> Created attachment 208174 [details]
> LegacyTrim patch v1

Patch released to master.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=616b29156c604ae0b8b4632a5abb451207d8e771
Comment 4 Remy Suen CLA 2012-01-24 12:18:11 EST 
Verified with I20120123-2200 on Windows 7.