Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366197

Summary:

incorrect fast modulo implementation

Product:

z_Archived

Reporter:

Atze van der Ploeg <atze.van.der.ploeg>

Component:

IMP

Assignee:

Jurgen Vinju <jurgen.vinju>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

atze.van.der.ploeg, rfuhrer

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Path to fix modulo bug	none

Description Atze van der Ploeg

2011-12-09 09:55:07 EST

Build Identifier: 20110615-0604

In org.eclipse.imp.pdb.facts.impl.fast.IntegerValue modulo was implemented such that -1 % 5 == 1, which is incorrect. It should be -1 % 5 == 4. Patch included.

Reproducible: Always

Comment 1 Atze van der Ploeg

2011-12-09 09:55:42 EST

Created attachment 208165 [details]
Path to fix modulo bug

Comment 2 Jurgen Vinju

2011-12-22 04:52:15 EST

applied and tested the patch