Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366124

Summary:

TCFModelProxy won't compile against Platform 3.8M4

Product:

[Tools] TCF

Reporter:

Pawel Piech <pawel.1.piech>

Component:

Debug

Assignee:

Project Inbox <tcf.debug-inbox>

Status:

RESOLVED FIXED

QA Contact:

Eugene Tarassov <eugene>

Severity:

normal

Priority:

CC:

cdtdoug

Version:

unspecified

Target Milestone:

1.0.0

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Patch with fix.	eugene: iplog-
Fix that will work against 3.7 and 3.8.	none
Updated fix that will work against 3.7 and 3.8.	eugene: iplog+

Description Pawel Piech

2011-12-08 18:29:26 EST

Created attachment 208130 [details]
Patch with fix.

I just checked in a major refactoring of the flexible hierarchy views in Platform Debug.  In the process, I removed some of the internal interfaces, one of which is used in TCFModelProxy.  Therefore TCF model proxy won't build against Juno starting with M4. The attached patch, uses a new API that replaces the internal method.  The bad news, is that with this patch, the agent won't build or run with Debug Platform pre 3.8M4.  The good news is that the new interface is an actual API and will be maintained.

If you want to keep the code building against with 3.8M4 as well as pre 3.8M4, you can replace the cast to ITreeModelContentProviderTarget with InternalTreeModelViewer instead.  Although, it is also internal and subject to change in future.

I aplogize for the breaking chagnes, they're always painful :-(  For more info on the refactoring, see bug 161435.

Comment 1 Pawel Piech

2011-12-12 14:43:33 EST

Created attachment 208283 [details]
Fix that will work against 3.7 and 3.8.

Comment 2 Pawel Piech

2011-12-12 14:46:59 EST

Created attachment 208284 [details]
Updated fix that will work against 3.7 and 3.8.

Comment 3 Eugene Tarassov

2011-12-12 17:13:04 EST

I have committed the second patch.
Thanks!