Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366103

Summary: Add a new filter rule to include/exclude based on a target runtime WTP 3.3.2
Product: [WebTools] WTP Common Tools Reporter: Rosendo Martinez <rosendo>
Component: wst.validationAssignee: Rosendo Martinez <rosendo>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: enhancement    
Priority: P3 CC: ccc, kaloyan, shr31223
Version: 3.3Flags: rosendo: pmc_approved? (david_williams)
rosendo: pmc_approved? (raghunathan.srinivasan)
rosendo: pmc_approved? (naci.dai)
rosendo: pmc_approved? (deboer)
rosendo: pmc_approved? (neil.hauge)
kaloyan: pmc_approved+
rosendo: pmc_approved? (cbridgha)
cbridgha: review+
Target Milestone: 3.3.2   
Hardware: PC   
OS: Windows XP   
Whiteboard: PMC_approved
Attachments:
Description Flags
R3_3_maintenance patch
none
R3_3_maintenance patch using org.eclipse.wst.common classes ccc: iplog+

Description Rosendo Martinez CLA 2011-12-08 15:14:17 EST 
Build Identifier: 

Cloning https://bugs.eclipse.org/bugs/show_bug.cgi?id=366065

This change is required in  WTP 3.3.2



Reproducible: Always
Comment 1 Rosendo Martinez CLA 2011-12-08 15:39:31 EST 
Created attachment 208119 [details]
R3_3_maintenance patch
Comment 2 Chuck Bridgham CLA 2011-12-08 16:34:31 EST 
Adding the description from original bug:


Add a new filter rule to extension point org.eclipse.wst.validation.validatorV2

Currently the extension point handles the following rules: fileext*, file*,
projectNature*, facet*, contentType*, pattern*

The idea is to add something like targetRuntime* with an id as attribute.

This change would affect not only the current extension point but also the
Validation Filters dialog.
Comment 3 Chuck Bridgham CLA 2011-12-08 16:35:39 EST 
approve - but because this changes an existing extension point in a maintenance release...   please add PMC review questions
Comment 4 Rosendo Martinez CLA 2011-12-14 15:47:00 EST 
PMC Review requested due to UI change

Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such.

This fix was requested by an adopter -IBM- to add a new filter rule (target runtime) to extension point org.eclipse.wst.validation.validatorV2.

This request affects not only user interface but also extension points.


Is there a work-around? If so, why do you believe the work-around is
insufficient?

There is no workaround.


How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added?

This has been tested by hand and by running the Java EE Tools JUnit bucket
(which includes validation JUnits) against it.


Give a brief technical overview. Who has reviewed this fix? 

Carl Anderson and Chuck Bridgham have reviewed this fix. 

Two extension points will be updated to support a new to rule to filter between target runtimes.

In addition, New Filter Rule wizard will be updated with a new option: "Target Runtime" and a new combobox where the defined workspace target runtimes will be shown.


What is the risk associated with this fix?

Medium  - this affects two extension points that could be used or not and UI wizards.
Comment 5 Rosendo Martinez CLA 2011-12-19 10:24:48 EST 
Created attachment 208559 [details]
R3_3_maintenance patch using org.eclipse.wst.common classes

Seems the use of the wst.server.core is causing build troubles. Attaching
a new patch and using org.eclipse.wst.common.project.facet.core classes.
Comment 6 Chuck Bridgham CLA 2011-12-19 10:59:12 EST 
Thanks for removing the server tools dep - much better
Comment 7 Roberto Sanchez Herrera CLA 2012-01-04 12:22:36 EST 
Code committed to HEAD and R3_3_maintenance for WTP 3.4 and 3.3.2. Resolving defect