Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366013

Summary:	[preferences] Polish preference UI for null annotations
Product:	[Eclipse Project] JDT	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Markus Keller <markus.kell.r>
Status:	VERIFIED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	daniel_megert, deepakazad, stephan.herrmann
Version:	3.8
Target Milestone:	3.8 M5
Hardware:	All
OS:	All
Whiteboard:

Description Dani Megert

2011-12-08 07:03:50 EST

I20111207-2118.

The preference UI for nulll annotations looks clumsy and the important parts are coming after the less important settings.

We should move the rarely used configuration of the annotations into a separate dialog which has a 'Restore Defaults' button. On the main page we add a 'Configure Annotations...' button (most likely at the end of the section).

Comment 1 Deepak Azad

2011-12-08 07:56:33 EST

(In reply to comment #0)
> the important parts are coming after the less important settings.
Placement of 'Use non-null as default' is debatable but I think the rest is OK.
('Use non-null as default' could probably be moved just below the explanation.)
 
> We should move the rarely used configuration of the annotations into a separate
> dialog which has a 'Restore Defaults' button. On the main page we add a
> 'Configure Annotations...' button (most likely at the end of the section).
Not a big fan of adding a separate dialog here
- The filter box on top let's you find stuff easily, a dialog will sort of break that :(
- Also what happens when you select 'Configure Problem Severity' action from a 'Problem hover' in Java editor? Do you open the preference page and the dialog on top of it? Feels clumsy to me..

Comment 2 Dani Megert

2011-12-08 08:28:14 EST

> - Also what happens when you select 'Configure Problem Severity' action from a
> 'Problem hover' in Java editor? Do you open the preference page and the dialog
> on top of it? 
Why would one need to do that? Only the annotations are on a separate dialog - not the all the other settings that the user really wants to tweak. Most of the users will go with the default annotations.

Comment 3 Deepak Azad

2011-12-08 09:39:32 EST

(In reply to comment #2)
> Why would one need to do that? Only the annotations are on a separate dialog -
I should have read comment 0 a bit more carefully, nevermind..

Comment 4 Markus Keller

2012-01-23 15:29:23 EST

Fixed with commit cfb978b48b0fa396e6d3029e19f05b31faa716e4.

Comment 5 Dani Megert

2012-01-24 09:29:48 EST

Verified in I20120123-1800.