Bugzilla – Full Text Bug Listing
| Summary: | Contribution for PictureControl | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Angelo ZERR <azerr> |
| Component: | Nebula | Assignee: | Wim Jongman <wim.jongman> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | azerr, mistria, pascal.leclercq, wim.jongman |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
| Attachments: | |||
|
Description
Angelo ZERR
Hi, I see that you include some software that you did not write yourself in: org.eclipse.nebula.widgets.picture\src\main\java\org\eclipse\nebula\widgets\picture\internal This could be a blocker. Can you replace these classes or include a reference to the original library? /* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. I tried to use the class and resize with layout. I could not get this working. Is this supported? Can users provide a layout on the control? Created attachment 208254 [details] Same zip than below with ASF License. According the comment https://bugs.eclipse.org/bugs/show_bug.cgi?id=365948#c1 source was changed to add ASF license for classes from org.eclipse.nebula.widgets.picture.internal package (coming from commons-io). (In reply to comment #2) > I tried to use the class and resize with layout. I could not get this working. > Is this supported? Can users provide a layout on the control? The choice which we have done is that the picture have static size. The size is setted with AbstractPictureControl#setMaxImageWidth and AbstractPictureControl#setMaxImageHeigtht or by setting a default image which set the size of the picture. This behaviour could be perhaps improved to manage your case? Regards Angelo This look quite good and useful. Moreover, it is very cool to see it running in RAP. Filed CQ 5906 https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5906 (In reply to comment #6) > Filed CQ 5906 > > https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5906 Hi, Here information about my contribution for PictureControl : 1. I authored 100% of the content I'm contributing Yes except for the 3 classes from org.eclipse.nebula.widgets.picture.internal package (ByteArrayOutputStream, IOUtils, LineIterator) code from Commons IO (Apache ASF). I have just copy/paste those 3 classes and change the package name. 2. I have the rights to donate the content to Eclipse I believe because I have already donate Eclipse code (Eclipse E4 CSS Engine and WTP Jetty). So I suppose Yes 3. I'm contributing it under the EPL Yes Regards Angelo Hi all, Here information about my contribution for PictureControl : 1. I authored 100% of the content I'm contributing Yes Same remarks as Angelo. 2. I have the rights to donate the content to Eclipse This works has been done on spare time. So I guess "yes" is the right answer 3. I'm contributing it under the EPL Yes Regards Pascal Created attachment 210168 [details] PictureControl+samples with copy of IOUtils of commons-io 2.0.1 Hi, Here a new zip which uses IOUtils from the commons-io 2.0.1 (to respect the commons-io version from the orbit http://download.eclipse.org/tools/orbit/downloads/drops/R20110523182458/). I have copy/paste IOUtils class (and some dependencies classes) in the project and rename the package or.appache.commons.io to org.eclipse.nebula.widgets.picture.internal. Regards Angelo Duplicating stuff is often not a good idea. The best way would be to create a CQ to request consumption of commons-io reusing the Orbit bundle, and then you would be allowed to put a dependency to commons-io in your code. (In reply to comment #10) Hi Mickael, > Duplicating stuff is often not a good idea. I agree with you, but in my case IOUtils is used just to copy InputStream to byte array. Code of that is not very complex and I think it's really shame to have dependencies to commons.io just for that. More commons* JAR libraries is real nightmare when you don't use OSGi because some libraries depends on commons.io XXXX version and some libraries depends on commons.io YYYY version. commons* JAR are used every time but version of thoe JAR are a very big problem. That's why I prefer duplicate code. > The best way would be to create a CQ to request consumption of commons-io > reusing the Orbit bundle, and then you would be allowed to put a dependency to > commons-io in your code. (In reply to comment #11) > IOUtils is used just to copy InputStream to > byte array. Ok. So you're right, it does not require more efforts. Created attachment 211032 [details] picture control+example+snippets+feature+tests Plug-In Hi Wim, Here a new patch which contains the picture control+example+snippets+feature+tests Plug-In with pom.xml. I have do the same thing than oscilloscope project. The example project contains PictureExampleTab to see the demo of the picture control. The snippets project is the same project than the old example project that I have renammed. So I think (if you agree) that you can push it to Git https://github.com/eclipse/nebula/ Hope I have done no error with POM. Rgards Angelo Thanks all! |