Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 365945

Summary: Column based New File... has side effect on Task Bar New File
Product: [ECD] Orion Reporter: Ken Walker <ken_walker>
Component: ClientAssignee: Susan McCourt <susan>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3    
Version: 0.3   
Target Milestone: 0.4 M1   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:

Description Ken Walker CLA 2011-12-07 13:46:38 EST
In the Navigator, first go into a subfolder.  Once in that folder use the Taskbar "New File" and then leave the slide out up.

Now in another folder visible in the Navigator use the Column based pop up to choose New File.  The old slide out under the task bar grows another pair of Ok/Dismiss items.
Comment 1 Susan McCourt CLA 2011-12-07 13:50:42 EST
this bug could be "just fixed" but it also begs the question.
Should the parameter slideout be modal to all commands?  
If you execute some command, even if it doesn't use parameters or slideout, should that close the active slideout?   Probably so....because the user could likely change the page context such that the command invocation (active item, etc.) doesn't make sense anymore.
Comment 2 Ken Walker CLA 2011-12-07 13:58:09 EST
If you leave up a New File and navigate somewhere else, then decide to use it, the wrong thing works.  Same with New Folder.
Comment 3 Ken Walker CLA 2011-12-07 13:59:54 EST
Sorry, I mean does not work properly.  Where you are in the Navigator isn't necessarily where the result takes place.
Comment 4 Susan McCourt CLA 2011-12-08 01:17:43 EST
(In reply to comment #3)
> Sorry, I mean does not work properly.  Where you are in the Navigator isn't
> necessarily where the result takes place.

exactly.  That's what I meant by... 
>user could
>likely change the page context such that the command invocation (active item,
>etc.) doesn't make sense anymore.

Right now the slideout knows who was active when it was invoked.
Comment 5 Susan McCourt CLA 2011-12-08 17:43:36 EST
fixed with d493130ad60ba071920cb7d5152d7ec64975653d

1 - the parameter collector still had the slideout page id hardcoded in places where instead it had to remember its invocation context.  That fixed the "grow a pair" problem
2 - if we rerender commands for which there is an open parameter collector, we close it.  So if the commands are rebound to a new context (like when you drill in the navigator) the slideout closes.
Comment 6 Susan McCourt CLA 2011-12-08 17:43:53 EST
.