Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 365934

Summary: MouseEvent#button, SWT#BUTTON*, and SWT#MOD* should spell out usual mapping
Product: [Eclipse Project] Platform Reporter: Markus Keller <markus.kell.r>
Component: SWTAssignee: Markus Keller <markus.kell.r>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: eclipse.felipe, markus.kell.r, remy.suen
Version: 3.8   
Target Milestone: 4.3 M3   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
proposed fix
none
patch 2
none
patch 3 none

Description Markus Keller CLA 2011-12-07 12:27:09 EST 
MouseEvent#button, SWT#BUTTON*, and SWT#MOD* should spell out the commonly used physical mapping of these buttons/keys.

I always have to guess the mapping of the middle and right mouse buttons, and the common order of modifiers.
Comment 1 Markus Keller CLA 2011-12-07 12:32:33 EST 
Created attachment 208058 [details]
proposed fix
Comment 2 Felipe Heidrich CLA 2011-12-09 12:17:56 EST 
Hi Markus, I can't apply this patch

could please create a commit in your local repo and export it to me using:
git format-patch -M origin/master

(supposing your master is only commit ahead of origin/master)
Comment 3 Markus Keller CLA 2012-02-14 16:39:19 EST 
Created attachment 211011 [details]
patch 2
Comment 4 Markus Keller CLA 2012-08-14 10:11:09 EDT 
Created attachment 219864 [details]
patch 3

Rebased patch onto master. This is a trivial Javadoc fix.