Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 365906

Summary:	GitQuickDiffProvider.isEnabled() breaks Quick Diff for CVS if Git provider is active
Product:	[Technology] EGit	Reporter:	Markus Keller <markus.kell.r>
Component:	UI	Assignee:	Kevin Sawicki <kevin>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, matthias.sohn
Version:	1.2
Target Milestone:	1.3
Hardware:	All
OS:	All
Whiteboard:

Description Markus Keller

2011-12-07 09:48:58 EST

Follow-up to bug 358245. That change fixed the problem for local files, but the current implementation still breaks Quick Diff for CVS files if the Git provider is active.

Test Case:
1. set Git as reference provider ('Quick Diff' preference page)
2. check out a CVS project
3. open a file and start typing
==> changes are not shown in ruler.

GitQuickDiffProvider#isEnabled() should call

    RepositoryProvider.
        getProvider(resource.getProject(), "org.eclipse.egit.core.GitProvider")

or do

    RepositoryProvider.getProvider(resource.getProject()) instanceof GitProvider

as in GitDocument#create(IResource)

Comment 1 Kevin Sawicki

2011-12-14 19:27:27 EST

Proposed fix pushed to http://egit.eclipse.org/r/4824

Comment 2 Matthias Sohn

2012-01-24 18:01:17 EST

merged as eb97196fe35bd5873e12301baa641f696b30c860

Comment 3 Dani Megert

2012-01-26 03:29:53 EST

Verified in 1.3.0.201201252016.