Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 365839

Summary:	Build failure due to bad HTML markup in doc
Product:	[Eclipse Project] Platform	Reporter:	Deepak Azad <deepakazad>
Component:	Releng	Assignee:	Platform-Releng-Inbox <platform-releng-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, john.arthorne, markus.kell.r, remy.suen
Version:	3.8
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:	stalebug

Description Deepak Azad

2011-12-07 04:13:32 EST

A couple of days back an integration build failed because of bad HTML markup in 1 file in jdt.doc.isv. See http://dev.eclipse.org/mhonarc/lists/platform-releng-dev/msg19378.html.

Build failure because of bad HTML markup is a bit extreme. Dani suggested the following two options
1) The help.buildHelpIndex Ant task from 'org.eclipse.help.base' gets changed, so that it no longer fails on invalid files.
2) We add error handling to the Ant file that builds the index, e.g. by using something like http://ant-contrib.sourceforge.net/tasks/tasks/trycatch.html.

Is there already an error handling task? If so, we should simply use it when calling the help.buildHelpIndex Ant task.

Comment 1 Markus Keller

2011-12-07 06:41:32 EST

Do we know which HTML error made the build fail?

Note that HTML errors can also come from generated Javadocs. These are hard to find locally, since setup to generate the Javadocs locally is not trivial, so a local CHKPII run usually doesn't include them.

Comment 2 Deepak Azad

2011-12-07 07:03:44 EST

(In reply to comment #1)
> Do we know which HTML error made the build fail?
Yes. The following commit fixed the problem (a missing closing " for an href attribute) http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=17a33e21f64db9b8223663d78ab0feb0417eade7

Comment 3 John Arthorne

2011-12-07 09:44:51 EST

It surprises me that this caused the build to fail. I thought we had these kind of doc problems all the time and they just manifest as chkpii problems in the test results.

Comment 4 Dani Megert

2011-12-07 09:53:59 EST

(In reply to comment #3)
> It surprises me that this caused the build to fail. I thought we had these kind
> of doc problems all the time and they just manifest as chkpii problems in the
> test results.

Most of the time yes. I guess there are some special cases which cause the Ant task to fail.

Comment 5 Lars Vogel

2019-11-14 03:35:54 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.