Bugzilla – Full Text Bug Listing
| Summary: | ReportMultiBookPage creates outline pages instead of letting the framework do it | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Remy Suen <remy.suen> | ||||
| Component: | BIRT | Assignee: | Dazheng Gao <gump_gao> | ||||
| Status: | NEW --- | QA Contact: | Xiaoying Gu <bluesoldier> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | bluesoldier, daniel_megert, gump_gao, zqian | ||||
| Version: | 3.7.1 | ||||||
| Target Milestone: | Future | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Remy Suen
Downgrading severity since the changes for bug 319621 have been reverted. Why is it that ReportMultiBookPage create the outline page's controls explicitly in its setActivePage(IPageBookViewPage) method? ----------- Access to a content outline page begins when an editor is activated. When activation occurs, the content outline view will ask the editor for its content outline page. This is done by invoking getAdapter(IContentOutlinePage.class) on the editor. If the editor returns a page, the view then creates the controls for that page (using createControl) and makes the page visible. ----------- Per the API spec'd in IContentOutlinePage, the 'Outline' view itself will handle the creation of the page's controls. BIRT should not be doing this themselves. Could someone from the BIRT team please address comment 2? This defect will prevent the report design editor from functioning when running on top of the Eclipse 4 SDK. (In reply to comment #3) > Could someone from the BIRT team please address comment 2? This defect will > prevent the report design editor from functioning when running on top of the > Eclipse 4 SDK. We'll take a look. Ping ! we're in M6 now, is there any update on this ? How can I reproduce this in Eclipse 4.2M5 + BIRT 3.7.1? I suspect this was already fixed in latest 3.7.2 code, but cannot verify it without the detailed steps. (In reply to comment #6) > How can I reproduce this in Eclipse 4.2M5 + BIRT 3.7.1? You can't reproduce the problem unless you apply the patch from bug 319621. > I suspect this was > already fixed in latest 3.7.2 code, but cannot verify it without the detailed > steps. I'm not so sure about that. ReportMultiBookPage is still manually creating the control in line 240. http://git.eclipse.org/c/birt/org.eclipse.birt.git/tree/UI/org.eclipse.birt.report.designer.ui.editors/src/org/eclipse/birt/report/designer/internal/ui/editors/schematic/ReportMultiBookPage.java (In reply to comment #7) > You can't reproduce the problem unless you apply the patch from bug 319621. > Can you attach the compiled java class file for the related patched code against 4.2M5? So I can simply replace the files in the jars for testing. > I'm not so sure about that. ReportMultiBookPage is still manually creating the > control in line 240. > http://git.eclipse.org/c/birt/org.eclipse.birt.git/tree/UI/org.eclipse.birt.report.designer.ui.editors/src/org/eclipse/birt/report/designer/internal/ui/editors/schematic/ReportMultiBookPage.java The root cause is the recursive call of the update action nested in the getAdapter() impl, our previous fix has added the check to simply discard those unnecessary update actions. (In reply to comment #8) > The root cause is the recursive call of the update action nested in the > getAdapter() impl, our previous fix has added the check to simply discard those > unnecessary update actions. I guess you're referring to f3525073d448f21435c283bb83e93d00eaf3217e. http://git.eclipse.org/c/birt/org.eclipse.birt.git/commit/?id=f3525073d448f21435c283bb83e93d00eaf3217e Is BIRT 3.7.2 not being contributed to Juno? Only 3.7.1 shows up from the Juno update site. I guess a manual installation is required. http://download.eclipse.org/birt/downloads/build.php?build=M-R1-3.7.2RC1-201201171144 Created attachment 210350 [details] patch (In reply to comment #9) > I guess you're referring to f3525073d448f21435c283bb83e93d00eaf3217e. > http://git.eclipse.org/c/birt/org.eclipse.birt.git/commit/?id=f3525073d448f21435c283bb83e93d00eaf3217e > Yes. > Is BIRT 3.7.2 not being contributed to Juno? Only 3.7.1 shows up from the Juno > update site. > > I guess a manual installation is required. > http://download.eclipse.org/birt/downloads/build.php?build=M-R1-3.7.2RC1-201201171144 The Juno update site still has BIRT 3.7.1. I've attached the patched class files for org.eclipse.birt.report.designer.ui.editors/src/org/eclipse/birt/report/designer/ui/editors/MultiPageReportEditor, you can replace them for the 3.7.1 jars for testing. I can confirm that the problem goes away with the birt-updatesite-3.7.2RC1.zip though would still recommend you investigate why you need to explicitly create the controls of an outline page yourself. (In reply to comment #11) > I can confirm that the problem goes away with the birt-updatesite-3.7.2RC1.zip > though would still recommend you investigate why you need to explicitly create > the controls of an outline page yourself. Glad to know it works. Yes, we'll try refactoring the code in the future. |