Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 365780

Summary: [dstore] codepage conversion should only occur for different encodings
Product: [Tools] Target Management Reporter: David McKnight <dmcknigh>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3    
Version: 3.2   
Target Milestone: 3.4 M4   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 365784    
Attachments:
Description Flags
patch to check encodings none

Description David McKnight CLA 2011-12-06 12:52:40 EST 
Currently the default codepage converter tries to do a conversion even if the remote and local encodings are the same and the file is of zero bytes.
Comment 1 David McKnight CLA 2011-12-06 12:59:00 EST 
There was already a fix for the zero-length case, although that needs to get backported - I'll do that with the encoding check.
Comment 2 David McKnight CLA 2011-12-06 13:03:24 EST 
Created attachment 208010 [details]
patch to check encodings
Comment 3 David McKnight CLA 2011-12-06 13:10:40 EST 
I've committed the change to the HEAD stream.