| Summary: | Support content type validation in navigate.command extension | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mark Macdonald <mamacdon> |
| Component: | Client | Assignee: | Mark Macdonald <mamacdon> |
| Status: | RESOLVED DUPLICATE | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | libingw, susan |
| Version: | 0.3 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Mark Macdonald
Not sure how this will be implemented but I have a questions here: Will the content type be part of the file meta data or something else? I am asking because in compare editor we are asking the diff provider to resolve the file name, type and content. In our own diff provider implementation, I am just using the file extension as the type when I get file name from the meta data. If I can't get the type from meta data, I may want some thing else but it has to be based on the file URI. Content type will be very important post .4 when RTC team wants to use Orion compare widget. One of their interests is to use syntax highlighting in the compare editor for different types of files. (In reply to comment #1) The content type isn't actually part of the metadata, but it can be looked up based on the file metadata. If the diff provider has access to the metadata, it can do that lookup. But as we just discussed offline, for highlighting purposes, the highlight-lookup code should be moved out of the setup.js glue and reused for the compare case. (see 364857) This was fixed by Susan's changes for bug 370903 *** This bug has been marked as a duplicate of bug 370903 *** |