Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 365625

Summary:	[Compatibility] Fix Intro's use of the ITrimManager
Product:	[Eclipse Project] Platform	Reporter:	Eric Moffatt <emoffatt>
Component:	UI	Assignee:	Eric Moffatt <emoffatt>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	bsd, remy.suen, stephen.francisco, stew
Version:	4.2
Target Milestone:	4.2 M5
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Eric Moffatt

2011-12-05 11:08:52 EST

Intro has a 'Go to Workbench' method that was used to collapse the Intro view down to an 'IntroLaunchBar'. Unfortunately the code uses internals which are not supported in 4.x.

For now I've implemented a stub ITrimManager which glosses over the issue but this must be removed in M5 and replaced by something that doesn't use internals. This will require that we have someone with UA commit rights in order to get the changes into GIT...

Comment 1 Eric Moffatt

2011-12-05 11:11:40 EST

Setting milestone to M5. I'll add Steve Francisco to see if we can arrange for him to help out on this...

Steve, I can do the initial version (at least) of the necessary changes but need help verifying and committing, can you help out ?

Comment 2 Steve Francisco

2011-12-05 14:01:15 EST

Eric, I don't quite have my committer wings yet, but I'm working towards it.  I'd be happy to help out where I can.

Comment 3 Eric Moffatt

2012-02-07 16:02:30 EST

Steve, I've wired this up so that it simply closes the IntroPart without attempting to create the Intro 'bar'...unless this gets pointed out as a hufe regression I think we should leave it as it is.

I'll mark this as FIXED and VERIFIED (just tried it in M5 and don't really think we have cycles to get the IntroBar back in 4.2.

Comment 4 Eric Moffatt

2012-02-07 16:03:17 EST

Verified in I20120127-1145.

Comment 5 Steve Francisco

2012-02-07 16:36:51 EST

Thanks Eric, that makes sense to me.

Comment 6 Stewart Francis

2013-01-18 07:04:34 EST

We were using the Trim Manager in unit tests in our RCP to check that our contributions were properly added to the workbench trim.  With the removal of this API, I can't work out another way that we can check our contributions were properly added, short of cycling through all the composites to find the trim bar, which I'd like to avoid!

Is there another way of achieving this using the backward compatibility API?  The stub that's been inserted here seems to remove functionality from the compatibility API (unless it wasn't considered API in the first place).  Please let me know if there's a more appropriate place I can discuss this.

Comment 7 Brian de Alwis

2016-01-08 14:22:07 EST

(In reply to Stewart Francis from comment #6, nearly 3 years later!)

The ITrimManager API was an internal API and is impossible to satisfy with E4.x.  In E4.x you should use the underlying MTrimmedWindow's trim bars to host your components.

The ITrimManager API assumed the trim widget had already been created and provided no way for the recreating the trim element.  Although we could wrap the trim element as an MToolControl within the appropriate trim area, such a wrapped control would be persisted out with the model, and the ITrimManager API provides no way to recreate the widget on restart.