Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 365597

Summary: View pane not closing when part is closed
Product: [Eclipse Project] Platform Reporter: John Arthorne <john.arthorne>
Component: UIAssignee: Remy Suen <remy.suen>
Status: VERIFIED FIXED QA Contact: Paul Webster <pwebster>
Severity: normal    
Priority: P3 CC: emoffatt, ob1.eclipse, pwebster, remy.suen
Version: 4.1   
Target Milestone: 4.2 M6   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Screen shot
none
ContextService patch v1 none

Description John Arthorne CLA 2011-12-05 09:26:20 EST 
I20111201 (4.2)

If I close a view below the editor, the view pane sticks around. This seems to be a painting problem - if I minimize/restore the window it disappears. This has been consistently reproducible so far today...
Comment 1 John Arthorne CLA 2011-12-05 09:26:50 EST 
Created attachment 207918 [details]
Screen shot
Comment 2 John Arthorne CLA 2011-12-05 16:47:56 EST 
I was showing this to Eric, and it looks like the pane actually closes by itself after several seconds, regardless of whether you minimize the window, etc. So rather than a paint problem it seems we've possibly introduced a performance regression where it takes us several seconds of processing between the view closing and the pane closing.
Comment 3 John Arthorne CLA 2012-01-20 14:44:31 EST 
Looked at this with Eric again today on I20120120-1200. It is much better now but the empty pane is still visible for about 500ms-1s before it disappears
Comment 4 Remy Suen CLA 2012-01-27 15:29:52 EST 
Created attachment 210217 [details]
ContextService patch v1

Contexts are activated and deactivated very frequently. However, if a context that's already active is asked to become active, we shouldn't do anything. The current code sets stuff in the eclipse context regardless of whether a context is active or not. We should check for this and avoid setting values into the eclipse context if it is not necessary
Comment 5 Remy Suen CLA 2012-01-27 15:30:52 EST 
(In reply to comment #4)
> Created attachment 210217 [details]
> ContextService patch v1

Paul, could you take a look at this? The fix is straightforward but perhaps I'm missing something obvious here.
Comment 6 Paul Webster CLA 2012-01-31 07:34:12 EST 
That looks good enough for now.

PW
Comment 7 Remy Suen CLA 2012-01-31 08:11:59 EST 
(In reply to comment #5)
> (In reply to comment #4)
> > Created attachment 210217 [details]
> > ContextService patch v1

Patch released to master.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=aaa101d65a906bb54b37f73455f7e097735809cd
Comment 8 Remy Suen CLA 2012-02-01 07:31:48 EST 
The pane closes almost instantaneously for me now with I20120131-2200 on Windows 7.

Please let me know if it is still slow for you, John.
Comment 9 Remy Suen CLA 2012-03-13 08:19:09 EDT 
Verified with I20120312-1730 on Windows 7 that part stacks close nearly instantaneously.