Bug 365593

Comment 1 Jan Koehnlein 2011-12-08 12:23:31 EST

Not sure about this: We're using the show inherited feature to show the visible members only, e.g. to show the complete set of multi dispatch methods for a given synthetic dispatcher. Also showing the overridden ones could be a bit confusing. We could also add a third mode (show all members) with the functionality form JDT.

Comment 2 Jan Koehnlein 2012-01-17 10:07:52 EST

Any other opinions? I'd vote for the third mode.

Comment 3 Sebastian Zarnekow 2012-01-17 11:33:21 EST

+1

Comment 4 Sven Efftinge 2012-01-17 14:16:48 EST

I think it should behave like in JDT it at least never confuses me.

Comment 5 Jan Koehnlein 2012-01-17 14:31:51 EST

In JDT there are no dispatch methods, which is the main reason why we did the special implementation for Xtend: To see all dispatch cases for a specific given synthetic dispatcher, including those from super classes. If the Xtend quick outline showed even overriden dispatch methods I guess it would become *very* confusing.

Personally, I am sometimes confused by JDT's quick outline, as it tends to not give you the closest implementation of an overridden method as the first match in a search.

Comment 6 Sven Efftinge 2012-01-17 14:37:12 EST

I use it to quickly navigate even to overridden members. I think grouping dispatch methods improves the structure a bit but doesn't seem to conflict with showing all declared members in the type hierarchy.

Maybe it depends on how and for what this feature is used. I typically also use the search field to quickly narrow down the number of shown elements.

Comment 7 Sebastian Zarnekow 2012-01-17 15:03:21 EST

(In reply to comment #4)
> I think it should behave like in JDT it at least never confuses me.

That's an interesting remark. I'm almost always confused by JDTs visualization, especially when it comes to unknown code bases / type hierarchies. If you consider the inherited #handleDispose in the class RichStringAwareSourceViewer or XFunctionTypeRefImplCustom#getType I'd select the wrong entry for sure. Especially if you compare the order in the quick outline when you filter for XFunctionTypeRefImplCustom#getType with XFunctionTypeRefImplCustom#getIdentifier.

A mode which visualized all methods that are currently not overwritten would be nice.

Comment 8 Sven Efftinge 2012-01-17 18:22:24 EST

Yes, ordering along the type hierarchy would be an improvement.
Still overridden methods can be called and are called, so they shouldn't be hidden. I for one use it regularly to navigate to the different implementations in methods like 'isVariableDeclarationRequired(...)' in our compiler hierarchy.

Comment 9 Sebastian Zarnekow 2014-09-01 11:37:06 EDT

Appears to be solved with the new outline impl.

Comment 10 Eclipse Webmaster 2017-10-31 10:48:57 EDT

Requested via bug 522520.

-M.

Comment 11 Eclipse Webmaster 2017-10-31 11:00:01 EDT

Requested via bug 522520.

-M.