Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 365577

Summary:

[Transaction Editing Domain] Transaction Editing domain id needs to be registered and change

Product:

[Modeling] Papyrus

Reporter:

Arthur Daussy <arthur.daussy>

Component:

Core

Assignee:

Arthur Daussy <arthur.daussy>

Status:

CLOSED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

alain.leguennec, cedric.dumoulin, faure.tristan

Version:

0.8.1

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Correction for Transaction Editing Domain	none
New correction	none
Email from Cedric Dumoulin on mailing list	none
New correction	none

Description Arthur Daussy

2011-12-05 07:20:02 EST

At the comment the current Transactional Editing Domain of Papyrus is never register in the registry. Moreover its ID is "SharedEditingDomain".
I would suggest to change it for something like org.eclipse.papyrus.SharedEditingDomain and register it in the registry.

Comment 1 Arthur Daussy

2011-12-05 07:22:38 EST

Created attachment 207912 [details]
Correction for Transaction Editing Domain

Correction for transaction Editing Domain

Comment 2 Arthur Daussy

2011-12-05 11:49:59 EST

Created attachment 207928 [details]
New correction

New correction with observation from dev list.

Comment 3 Arthur Daussy

2011-12-05 11:52:29 EST

Committed on the 0.8.X branch.
Will be backported soon..

Comment 4 Alain Le Guennec

2011-12-06 09:10:45 EST

Just a quick question:
I have not seen any de-registration.
Won't the registration cause a leak?

Comment 5 Arthur Daussy

2011-12-07 05:12:32 EST

Yes the registration is here:
TransactionalEditingDomain.Registry.INSTANCE.add(PAPYRUS_EDITING_DOMAIN_ID, transactionalEditingDomain);

However Cedric raise another problem (see email in attachment) that is a real problem when multiple papyrus editor are open.
I am currently looking into it. Let you know when I have found a better solution.

Comment 6 Arthur Daussy

2011-12-07 05:14:44 EST

Created attachment 208044 [details]
Email from Cedric Dumoulin on mailing list

Exchange on mailing list

Comment 7 Arthur Daussy

2011-12-07 06:04:31 EST

Hi,

 The main problem with no registration of the editing domain is you can not use the extension point of EMF transaction to register listener easily:
            org.eclipse.emf.transaction.listeners
As creation of the Papyrus Editing Domain is hand made ( see org.eclipse.papyrus.resource.ModelSet)we have integrate this mechanism into MDT Papyrus. With this solution Papyrus transactional editing domain will not need to be registered.

However we have not been able to find where the Transactional Editing domain was dispose. So as Alain said, it still may persist some leak. Cedric do you have any idea on this topic. If none, I will start a discussion about it on the dev list.

Regards.

Comment 8 Arthur Daussy

2011-12-07 06:06:13 EST

Created attachment 208047 [details]
New correction

Comment 9 Arthur Daussy

2012-01-09 05:21:36 EST

Committed on trunk and branch 0.8.x.