Bug 365475

Comment 1 Gernot Kvas 2011-12-02 15:11:37 EST

Created attachment 207864 [details]
Patch for HSQLDB

A patch adding support for HSQLDB. Includes hsqldb.jar.

Comment 2 Juergen Kissner 2011-12-04 18:17:11 EST

Hi Gernot,

Thanks for your interest in the DBAccess project and thank your for your contribution.

I have problems applying the patch; the root of the directories in you patch seem to be "a" and "b". Could you please re-check you upload?

Please also note that the Eclipse Foundation has a strict legal process to ensure IP cleanliness. For further referece, please see 
http://wiki.eclipse.org/Development_Resources#Everyone:_IP_Cleanliness and
http://www.eclipse.org/legal/committerguidelines.php.

It has to be clear, which parts of the contribution is your own work, and which part comes from other sources. Please see http://www.eclipse.org/tm/development/committer_howto.php#external_contrib. It contains  questions that have to be answered in the IP process.

Is it possible to submit an initial contribution that is kept to a minimum (and can then be extended)? For the database software, we presumably need a separate CQ (contributors questionaire). Maybe we could first aim for a solution similar to the the one for MySQL that does nor require the database software? 

-- Juergen

Comment 3 Gernot Kvas 2011-12-11 14:50:51 EST

Created attachment 208231 [details]
A minimalist patch for HSQLDB support

Comment 4 Gernot Kvas 2011-12-11 14:51:19 EST

Created attachment 208232 [details]
HSQLDB mock plugin

Comment 5 Gernot Kvas 2011-12-11 14:51:42 EST

Created attachment 208233 [details]
HSQLDB feature

Comment 6 Gernot Kvas 2011-12-11 14:59:38 EST

Hi Juergen,

I've split the initial patch and replaced the HSQLDB wrapper plugin with a mock one. The patches now contain no additional code from other sources. This should simplify things quite a bit. 

Gernot

Comment 7 Gernot Kvas 2011-12-11 15:18:49 EST

Created attachment 208234 [details]
HSQLDB mock plugin - fixed pom

Comment 8 Juergen Kissner 2012-01-16 17:14:39 EST

(In reply to comment #7)
> Created attachment 208234 [details]
> HSQLDB mock plugin - fixed pom

Hi Gernot,
I cannot see any reason why we couldn't include HSQLDB.
However, before taking into account HSQLDB, I would first like to see how we can include your H2 contribution (https://bugs.eclipse.org/bugs/show_bug.cgi?id=365469). 

Thanks for your effort,

Jürgen

Comment 9 Juergen Kissner 2012-01-22 15:25:38 EST

Hi Gernot,
in the meanwhile we had a thorough discussion within the Gemini umbrella project about the best way of integrating your contributions. The goal is to comply with the legal requirements of the Eclipse Foundation and at the same time to minimize the administrative overhead such that the changes can be incorporated as soon as possible. 

This is what we came up with:
The best and easiest way is to minimize the amount of contributed code to the necessary minimum. That is, we would like our contributors to submit the support for a new database platform such that it does not contain any boilerplate stuff such as licenses, auto-generated Eclipse project meta data,...

Applied to your contribution, that means  please re-submit the extract that contains the genuine part. This is everything in the 
hsqldb/org.eclipse.gemini.dbaccess.hsqldb/src directory, To be more specific, it is the contents of the following folders and subfolders:
src/
METAINF/
org/eclipse/gemini/dbaccess/hsqldb/
src/org/eclipse/gemini/dbaccess/hhsqldb/service/

With that we stay well below the 250 lines barrier, beyond which a much higher administrative effort would be required.

I think this strategy helps you as contributors and us as committers.

What do you think?

Best Regards,
  Jürgen

Comment 10 Gernot Kvas 2012-01-24 15:34:20 EST

Thanks for the effort.  I'll prepare a bare bones version on the weekend

Comment 11 Gernot Kvas 2012-08-17 03:37:11 EDT

Created attachment 219991 [details]
Stripped patch for HSQL

Patch that should be well below the 250 lines restriction

Comment 12 Juergen Kissner 2012-09-19 08:15:56 EDT

Hi Gernot,
thanks for the new attachment 219991 [Details] [details]!

I have created the follwing change in Gerrit:

https://git.eclipse.org/r/#/c/7822/

Because we want to prepare a release soon, I have already merged the change into git, and triggered a build.

Here is update site of the snapshot build result:

https://hudson.eclipse.org/hudson/job/gemini-dbaccess/lastSuccessfulBuild/artifact/gemini.dbaccess.updatesite/target/site/

Please let me know, if it the new DBAccess HDBSQL feature works for you.

Best Regards,
  Juergen

Comment 13 Juergen Kissner 2012-09-19 10:03:57 EDT

Change merged into git with
http://git.eclipse.org/c/gemini.dbaccess/org.eclipse.gemini.dbaccess.git/commit/?id=15dc6a06ecb557ed830241b94f953f1e43a61f76

Comment 14 Juergen Kissner 2012-09-26 06:01:03 EDT

Hi Gernot,

the HSQLDB feature will be incorporated in Milestone 1.1.0 M3, which will be available soon.

Thanks a lot for your contribution!

Best Regards,
  Juergen

Comment 15 Gernot Kvas 2012-09-26 07:54:38 EDT

Hi Juergen,

Thanks for your efforts!

Gernot