Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 365362

Summary:	[commands] use of ARIA roles on UI elements
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Max Li <maxli>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	carolynmacleod4, maxli
Version:	0.3	Keywords:	accessibility
Target Milestone:	0.5 M1	Flags:	maxli: review?
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:
Bug Blocks:	365361

Description Susan McCourt

2011-12-01 15:51:08 EST

Discussed accessibility issues with Carolyn, and she mentioned that we will likely want to assign ARIA roles to some of our UI elements.  For example, the command framework renders spans, links, image nodes, etc. that are intended to behave like buttons.  We could assign a button role so that screen readers, etc. do the right thing.

Carolyn will annotate this bug with further information.

Comment 1 Carolyn MacLeod

2011-12-02 03:19:36 EST

List of ARIA roles, and for each one, when to use, and states and properties that can be used on an element with that role.
http://www.w3.org/TR/wai-aria/roles#role_definitions

Comment 2 Max Li

2012-02-03 15:15:45 EST

I've gone through all of Orion and added roles on the few pages where I haven't had to in fixing other bugs.

I also added tabindex properties and such in order to fully make these UI elements accessible.

I've put it in the following commit in the bug365362 branch.

https://github.com/max-li/orion.client/commit/f5f3d19fa90c221b1978236cb77ae1a8ae9dbf43

Comment 3 Max Li

2012-03-30 21:09:29 EDT

I've pretty much been doing this as I've been going along, but I did a pass through and added a few bits and pieces that I missed in other bugs.

fixed in

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=71d64971bd1260c68bf4e96b20ba1b8eb9db7724
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=6e1411b390cefac45873ff8dd56a9bd26f233adc