Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 365278

Summary: Empty Servers View Default Message (Patch included)
Product: [WebTools] WTP ServerTools Reporter: Dimitar Iordanov <dimitar.iordanov>
Component: wst.serverAssignee: Elson Yuen <eyuen7>
Status: RESOLVED FIXED QA Contact: Elson Yuen <eyuen7>
Severity: minor    
Priority: P3 CC: cbridgha, kaloyan
Version: unspecifiedFlags: eyuen7: pmc_approved? (david_williams)
eyuen7: pmc_approved? (raghunathan.srinivasan)
eyuen7: pmc_approved? (naci.dai)
eyuen7: pmc_approved? (deboer)
eyuen7: pmc_approved? (neil.hauge)
kaloyan: pmc_approved+
cbridgha: pmc_approved+
Target Milestone: 3.3.2   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/109086
Whiteboard: PMC
Bug Depends on:    
Bug Blocks: 368778    
Attachments:
Description Flags
ServersView2, message.properties, Messages.java
eyuen7: iplog+
v1.0
none
v1.1 none

Description Dimitar Iordanov CLA 2011-12-01 03:28:19 EST 
Build Identifier: Version: 4.1.0 Build id: I20111028-1100

The Servers could use a default message when there are no servers defined. 
The message/ hyperlink would prompt the user to open the Define New Server Wizard.
Such behavior is already implemented for the Search View.
I've already created a patch. And I'll submit it just now.
Hope u likes it XD.
Regards,
Iordanov

Reproducible: Always

Steps to Reproduce:
1. Open Servers View (Window-> Show View-> Servers)
2. Remove all server entries if any.
3. Look at an empty view.
Comment 1 Dimitar Iordanov CLA 2011-12-01 03:33:53 EST 
Created attachment 207781 [details]
ServersView2, message.properties, Messages.java

A minor change to the createControl() of the view. 

This patch is also applicable for versions:
org.eclipse.wst.server.ui_1.1.405 (eclipse 4.2M3 )
org.eclipse.wst.server.ui_1.1.306… (Eclipse 3.7M7 )
org.eclipse.wst.server.ui_1.1.205… (Eclipse 3.6...)
Comment 2 Elson Yuen CLA 2011-12-28 14:01:16 EST 
Created attachment 208831 [details]
v1.0

Thanks for submitting the patch.  The logic in general looks good except that the separated message will not work for NL scenarios.  Here is an updated patch based on the original submission with the hyperlink link message fixed so that it can work well on NL scenarios and fixing typo on message.
Comment 3 Elson Yuen CLA 2011-12-28 14:10:52 EST 
Created attachment 208834 [details]
v1.1

The previous version v1.0 of the patch works with 32M stream.  This new version v1.1 of the patch works with the 33M.
Comment 4 Elson Yuen CLA 2011-12-28 14:18:32 EST 
Code dropped to 32M and HEAD
Comment 5 Elson Yuen CLA 2012-01-13 11:07:22 EST 
Typo on my previous comment, I mean Code dropped to 33M and HEAD
Comment 6 Elson Yuen CLA 2012-01-16 15:56:27 EST 
Adding PMC approval since it involves adding new string
Comment 7 Chuck Bridgham CLA 2012-01-16 16:25:39 EST 
approved
Comment 8 Kaloyan Raev CLA 2012-01-17 02:28:41 EST 
Nice usability improvement.
Comment 9 Dimitar Iordanov CLA 2012-05-23 06:51:34 EDT 
You guys,
The fix should be present in 4.2 right? 
If not, is it possible to include it for 4.2 RC2?
Thanks
Comment 10 Kaloyan Raev CLA 2012-05-23 06:57:30 EDT 
It's there. Also in Indigo SR2.
Comment 11 Eclipse Genie CLA 2017-10-11 16:37:41 EDT 
New Gerrit change created: https://git.eclipse.org/r/109086