Bug 365249

Comment 1 John Arthorne 2011-11-30 16:48:36 EST

(note since we consume jetty via the platform repository, we would need to do some work anyway at this point in our build to consume something other than the one provided by the platform)

Comment 2 John Arthorne 2011-12-07 09:42:33 EST

I'm going to stay on platform M3 for the current Orion milestone, and move to new Jetty/servlet API next week.

Comment 3 John Arthorne 2011-12-14 13:09:17 EST

Just to document my changes, I have made the following changes to Orion base:

- org.mortbay.jetty.server
- org.mortbay.jetty.util
- org.apache.jasper
- org.apache.commons.el

+ com.sun.el
+ org.eclipse.jetty.server
+ org.eclipse.jetty.util
+ org.eclipse.jetty.http
+ org.eclipse.jetty.io
+ org.eclipse.jetty.continuation
+ javax.servlet
+ org.apache.jasper.glassfish

Also org.eclipse.equinox.http.jetty moves to version 3.0.0

I don't understand why we didn't need to have javax.servlet in our feature in the past.. maybe it was bundled inside Jetty? Anyway the current configuration seems to be working and I am working on the corresponding builder changes.

Tom, just CCing you FYI in case something looks wrong to you.

Comment 4 Thomas Watson 2011-12-14 13:27:41 EST

(In reply to comment #3)
> Just to document my changes, I have made the following changes to Orion base:
> 
> - org.mortbay.jetty.server
> - org.mortbay.jetty.util
> - org.apache.jasper
> - org.apache.commons.el
> 
> + com.sun.el
> + org.eclipse.jetty.server
> + org.eclipse.jetty.util
> + org.eclipse.jetty.http
> + org.eclipse.jetty.io
> + org.eclipse.jetty.continuation
> + javax.servlet
> + org.apache.jasper.glassfish
> 
> Also org.eclipse.equinox.http.jetty moves to version 3.0.0
> 
> I don't understand why we didn't need to have javax.servlet in our feature in
> the past.. maybe it was bundled inside Jetty? Anyway the current configuration
> seems to be working and I am working on the corresponding builder changes.
> 
Strange, I would expect you to need the javax.serlvet bundle.

> Tom, just CCing you FYI in case something looks wrong to you.

There is no point in having com.sun.el if you don't include javax.el API.  I don't think com.sun.el will resolve without it.  I am no expert in expression language, but I am not convinced our support for javax.el is working properly.  See bug363473.

Comment 5 John Arthorne 2011-12-14 16:29:37 EST

I was missing a bunch of stuff. PDE wasn't complaining about these being missing but I think it doesn't handle package imports. Here is what I have added since the previous list:

+ org.eclipse.jetty.servlet
+ org.eclipse.jetty.security
  (required by jetty.servlet)
+ org.eclipse.jetty.servlets
  (not in Eclipse SDK, but we have a dependency on GZipFilter in this bundle)
+ javax.el
  (as mentioned by Tom this is the API to go with the impl in com.sun.el)

Comment 6 John Arthorne 2011-12-14 16:30:09 EST

Also recording so I don't lose it, this jetty dependency graph is very handy:

http://wiki.eclipse.org/Image:Jetty-7.0.0-dependencies.png

Comment 7 John Arthorne 2011-12-15 17:18:23 EST

Marking fixed. Builds >= 20111214-2230 are running on Jetty 8.