Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 365195

Summary: [Tooling] Double-click on editor tree element should open the tree
Product: [Eclipse Project] e4 Reporter: Lars Vogel <Lars.Vogel>
Component: UIAssignee: Nobody - feel free to take it <nobody>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: bsd, Lars.Vogel, tom.schindl
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Patch none

Description Lars Vogel CLA 2011-11-30 09:01:33 EST 
Hi Tom,

a nice feature would be if I click in the model editor tree, that the children are opened.
Comment 1 Lars Vogel CLA 2012-05-06 16:42:31 EDT 
Created attachment 215149 [details]
Patch

Patch attached to extend the tree via mouse click.
Comment 2 Brian de Alwis CLA 2012-05-07 12:00:23 EDT 
Hmm, the patch is different from the title: the patch will expand on a single-click, whereas the title says double-click.  It also only affects the main tree — what about the other trees embedded in the various editors?

(Not to mention that it runs counter to most UIs I've seen.)

I'd personally prefer that double-clicking actually switch the editor to open that element.
Comment 3 Thomas Schindl CLA 2012-05-07 12:04:47 EDT 
If we introduce something like this it has to be a preference option
Comment 4 Lars Vogel CLA 2012-05-07 13:26:41 EDT 
@Tom: A preference option would be overdesign IMHO. Its like the JDT package explorer which also opens on double-click. I don't think they have a preference option for this (I might be wrong)

@Brian: Sorry, I started with double-click and then I really liked the single-click. I can change the patch to double-click if Tom and you say that this would be accepted.

With regards to the comment "Not to mention that it runs counter to most UIs I've seen", at least in my training people conplain about this. I think Java devs are used to the JDT Package Explorer which shows a similar behavior. 

I can also look at the tree in the editors once the main tree has been adjusted, that is very the main interaction happens it would really help me for my trainings. ;-)
Comment 5 Thomas Schindl CLA 2012-05-07 13:30:46 EDT 
Double click by default is fine - if you want to allow single click you need to add a preference option
Comment 6 Lars Vogel CLA 2012-05-07 13:32:31 EDT 
@Tom: Agree, single-click would not "standard" JDT and should be avoided. I try to update the patch later today or this week.

Thanks.
Comment 7 Nobody - feel free to take it CLA 2012-08-27 14:49:39 EDT 
Agree single click is not suitable as it messes with the selection idea. 

Lars, any plan to modify the patch or should I modify it?
Comment 8 Lars Vogel CLA 2012-08-27 16:05:43 EDT 
@Sopot: In case you have time, please change it. I definitely want to change this, but stuff is a bit crazy hear. I guess thats good. :-)
Comment 9 Lars Vogel CLA 2012-09-02 15:55:59 EDT 
Fixed with 58d5ddab3db883c3bb58824063612299c7b9666c, double-click now expands the tree.
Comment 10 Nobody - feel free to take it CLA 2012-09-02 16:01:24 EDT 
Beat me while I was in the push screen. I changed the Assigned field for a reason ;)