Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 365172

Summary:	Shape Selection Info Solid Line
Product:	[Modeling] Graphiti	Reporter:	Joao Mising name <joao.p.r.silveira>
Component:	Core	Assignee:	Felix Velasco <felix.velasco>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	felix.velasco, joao.p.r.silveira, matthias.gorning, michael.wenz
Version:	0.8.0	Flags:	michael.wenz: kepler+
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:	Kepler M3 Theme_bugs

Description Joao Mising name

2011-11-30 04:54:35 EST

Build Identifier: 20110916-0149

Trying to modify Selection Info for Shape LineStyle to solid results always in a dashed line.


Reproducible: Always

Steps to Reproduce:
1.Override getSelectionInfoForShape in ToolBehaviorProvider.
2.Set LineStyle to SOLID.
3.

Comment 1 Michael Wenz

2011-11-30 07:58:22 EST

Added to queue

Comment 2 Michael Wenz

2012-08-21 10:12:50 EDT

Marked for Kepler

Comment 3 Felix Velasco

2012-10-05 10:29:16 EDT

I've been looking into this, and I have a couple questions regarding the scope of the bug. Only linestyle is pointed, but there are other attributes that aren't used, and I'm not totally sure they should:

 * Color: used when selecting connections, but not when selecting shapes. Should be used for the color of the selection surrounding handler?
 * HandleForegroundColor: Not used. At all. It should be used for the color or the resizing handlers, shouldn't it?
 * HandleBackgroundColor: The same, but with the background (filling color) of those handlers

Besides that, resizing handlers use different colors for primary and secondary selections. Should there be two new colors, HandleForegroundSecondaryColor, and HandleBackgroundSecondaryColor? Otherwise, there would be no way to tell primary from secondary selected shapes.

What do you think?

Comment 4 Matthias Gorning

2012-10-09 08:26:06 EDT

Pushed fix for review to Gerrit: 

https://git.eclipse.org/r/#/c/8097/1

The fix covers only the line style.

@Felix: Sorry, I saw too late that you have assigned the bug to you.

You are right. There are many methods of ISelectionInfo unused. We should use it, if it makes sense, otherwise we should remove them from the interface.

To the handle color: Yes, I think we need new methods:

getHandlePrimarySelectionForegroundColor
getHandlePrimarySelectionBackgroundColor
getHandleSecondarySelectionForegroundColor
getHandleSecondarySelectionBackgroundColor

and also the set methods.

Comment 5 Matthias Gorning

2012-10-10 07:19:46 EDT

I've also created a new bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=391523 which covers the other mentioned problems with the selection info.