Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 365104

Summary: LaunchConfigurationEditDialog does not return correct return code when the user clicks "Continue"
Product: [Eclipse Project] Platform Reporter: Samantha Chan <chanskw>
Component: DebugAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: Michael_Rennie
Version: 3.7.1   
Target Milestone: 3.8 M4   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 365108, 365222    
Attachments:
Description Flags
fix none

Description Samantha Chan CLA 2011-11-29 12:01:20 EST 
The fix here:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=338847

introduced a major regression in our product.

The fix causes the LaunchConfigurationEditDialog to always return "cancel" as the return code even when the user has clicked the "Continue" button.  As a result, our launch configuration delegate is broken and our customer is unable to launch.

Requesting a fix in the LaunchConfugrationEditDialog to return "OK" when the "continue" button is pressed.  Return "cancel" if the cancel button is pressed.
Comment 1 Michael Rennie CLA 2011-11-29 12:45:53 EST 
This should also be fixed in 3.7.2. I opened bug 365108 to track that work.
Comment 2 Michael Rennie CLA 2011-11-29 13:09:48 EST 
Created attachment 207676 [details]
fix

Patch that makes sure the continue button always returns the correct result