Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 365081

Summary: [Compatibility] Checked menu items may not reflect actual backing state
Product: [Eclipse Project] Platform Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: pwebster
Version: 4.2   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard: stalebug

Description Remy Suen CLA 2011-11-29 10:55:04 EST
1. Confirm that 'Build Automatically' is checked in the 'Project' menu.
2. Window > New Window
3. Confirm that 'Build Automatically' is checked in the new window's 'Project' menu.
4. Project > Build Automatically
5. Confirm that 'Build Automatically' is now unchecked in the new window's 'Project' menu.
6. Go back to the original window.
7. See that 'Build Automatically' remains checked in the original window's 'Project' menu.

Probably similar to bug 339687.
Comment 1 Remy Suen CLA 2011-11-29 13:12:18 EST
There's a preference listener that listens for preference changes and updates the actions. Since the actions are replaced by handled items, the toggle state changes are essentially unused by the renderer.
Comment 2 Remy Suen CLA 2011-11-29 16:19:02 EST
Paul, when we convert action contribution items into a handled menu item, should we also keep a property listener on the original action to ensure that changes made to the action are also propagated to the model? This problem is likely going to be rampant for the actions in the main menu bar given that those are created by an advisor and can be programmatically modified as desired.
Comment 3 Paul Webster CLA 2011-11-30 13:18:06 EST
Technically, if we switch to handled menu items were saying that it's a command.  If it's a toggle command, then we have to somehow manage the ToggleState and propagate that to the model, no?

PW
Comment 4 Lars Vogel CLA 2019-11-14 03:37:22 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.