Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 365042

Summary: [Contributions] Contributed Status toolbar is smaller than the default status toolbar, causing clipped controls
Product: [Eclipse Project] Platform Reporter: Filip Wieladek <filip_wieladek>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: gheorghe, Michael.Valenta, pwebster, remy.suen
Version: 3.6.2   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=330106
Whiteboard: stalebug
Attachments:
Description Flags
Image showing the bug none

Description Filip Wieladek CLA 2011-11-29 06:33:30 EST 
Build Identifier: M20100211-1343

We changed our implementation of contributed status toolbars as written in this bug report: 

https://bugs.eclipse.org/bugs/show_bug.cgi?id=330106

Now our code looks like:
   <extension
         point="org.eclipse.ui.menus">
      <menuContribution
            locationURI="toolbar:org.eclipse.ui.trim.status">
         <toolbar
               id="com.ibm.team.workitem.rcp.ui.SearchBarGroup">
            <control
                  class="com.ibm.team.workitem.rcp.ui.internal.quicksearch.SearchBarTrim"
                  id="com.ibm.team.workitem.rcp.ui.SearchBar">
            </control>
         </toolbar>
      </menuContribution>
      <menuContribution
            locationURI="toolbar:org.eclipse.ui.trim.status">
         <toolbar
               id="com.ibm.team.workitem.rcp.ui.WorkitemActivationGroup">
            <control
                  class="com.ibm.team.workitem.rcp.ui.internal.activation.ActiveWorkItemWorkbenchTrim"
                  id="com.ibm.team.workitem.rcp.ui.WorkitemActivationTrim">
            </control>
         </toolbar>
      </menuContribution>
   </extension>

The toolbars are displayed, but the controls are clipped on Linux running gnome. In general it seems that the contributed toolbars are given less vertical space than the built in status bars. 

On the attached image you can see the clipping on the left side and on the right side you can see the "bar" part of the progress status bar which has more vertical space than our contributed bars. 

Reproducible: Always
Comment 1 Filip Wieladek CLA 2011-11-29 06:35:10 EST 
Created attachment 207644 [details]
Image showing the bug

Image showing the bug
Comment 2 Filip Wieladek CLA 2011-11-29 06:36:51 EST 
I forgot to mention that the toolbars were working correctly with the old syntax which is described here:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=330106
Comment 3 Paul Webster CLA 2011-11-29 07:47:45 EST 
Eric, can you take a look at this?

PW
Comment 4 Eric Moffatt CLA 2011-11-29 15:22:41 EST 
Adding Bogdan, apparently this is a known SWT defect which has already been addressed in 3.7. Not sure whether it's possible to back-port or not...

Bog, could you point us to the SWT defect that this was fixed against ??
Comment 5 Bogdan Gheorghe CLA 2011-11-29 23:05:00 EST 
Looking closely at the image posted, it looks like this is a different bug than the one I was thinking of (which had to do with Cairo clipping problems).

You could try running "export GDK_NATIVE_WINDOWS=true" in a terminal and then launching Eclipse to see if that makes a difference.
Comment 6 Filip Wieladek CLA 2011-11-30 03:59:27 EST 
(In reply to comment #5)
> Looking closely at the image posted, it looks like this is a different bug than
> the one I was thinking of (which had to do with Cairo clipping problems).
> 
> You could try running "export GDK_NATIVE_WINDOWS=true" in a terminal and then
> launching Eclipse to see if that makes a difference.

Thanks for the response.

I tried that, but I still get differently sized "bars" (which would indicate that I still get less vertical screen space). The bars seem to have a correct size on windows.
Comment 7 Filip Wieladek CLA 2011-12-02 03:56:57 EST 
Is this the right place for this issue? Is this issue being looked into? If not, we will have to use the old syntax which did not break the UI
Comment 8 Paul Webster CLA 2011-12-02 07:48:56 EST 
(In reply to comment #7)
> Is this the right place for this issue? Is this issue being looked into? If
> not, we will have to use the old syntax which did not break the UI

Yes, this is the correct place.  We believe the underlying problem is bug 183003

PW
Comment 9 Remy Suen CLA 2011-12-09 14:27:12 EST 
There is a patch in bug 366214 for getting the experimental trim contributions API to work in some more cases.
Comment 10 Lars Vogel CLA 2019-11-14 03:44:15 EST 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.