Bugzilla – Full Text Bug Listing
| Summary: | Initial Code Contribution - SnipMatch Plug-in | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Doug Wightman <douglasw> | ||||||
| Component: | Recommenders | Assignee: | Marcel Bruch <marcel.bruch> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | zi | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Doug Wightman
Created attachment 207640 [details]
source code
To the best of my knowledge I hereby state that we - Zi Ye and me, Doug Wightman -
1. authored 100% of the content we are contributing
2. have the rights to contribute the content to Eclipse
3. are contributing the content under the EPL
Doug, I guess there is a typo but I have to ask. You write: "We are not open-sourcing this plug-in." Do you mean "now" instead of "not"? Correction: I meant to write "we are now open-sourcing this plug-in". :) (In reply to comment #0) > Build Identifier: > > SnipMatch is a snippet search tool with a shared, central repository. You can > learn more and watch a video at: snipmatch.org. We are not open-sourcing this > plug-in. > > Reproducible: Always Yes, sorry about that! (In reply to comment #2) > Doug, I guess there is a typo but I have to ask. You write: > > "We are not open-sourcing this plug-in." Do you mean "now" instead of "not"? Good to hear :) The attached zip file only contains the server files. I guess the client code also belongs to the contribution? If so, can you add it to the attached zip file, i.e., replace the attachment with a new, more complete one? To the best of my knowledge I hereby state that we - Doug Wightman and me, Zi Ye - 1. authored 100% of the content we are contributing 2. have the rights to contribute the content to Eclipse 3. are contributing the content under the EPL Created attachment 207815 [details]
source code
Hi Doug. Thanks for the updated sources. I initiated/requested the IP check. Doug, Zi (probably Zi), can you answer Sharon's questions below to solve the last issues before the contribution get's accepted? ------- Comment #8 From Sharon Corbett 2012-01-23 16:50:40 [reply] ------- Hi Marcel: I've completed the initial triage and I'll need your help to understand the following: 1. SnippetMatchEnvironment.java and MatchEnvironment.java include the following comment, "must be implemented by derived classes". I'd like your help to understand this comment. 2. SubmitBox.java includes the following, "By checking the box above, you confirm that you have full rights to release the code in this snippet, and agree to release it to the public domain. You also understand that "Language Interfaces is not responsible for any misuse of this code". I'd like your help to understand this comment. 3. SnipMatchPlugin.java contains, "this feature is only available for registered users". Is this no longer applicable? 4. JavaSnippetMatchEnvironment.java references the use of Code Assist. Is it correct to understand there is no source contained from Code Assist? 5. Feature.xml contains copyright to SnipMatch as well as a license URL that is not to the EPL. I'm guessing both items are no longer applicable? Thanks for your time. Kind Regards, Sharon Thanks Marcel and Sharon, sorry for the delay. Here are our answers: 1. This comment is redundant and can be removed. The "abstract" keyword already makes that clear. 2. We mentioned this in a prior email - it seems to make sense to have snippet contributors indicate that they have the right to share the code that they are publicly sharing, and that we should also (at least initially) only accept code that all our users are then free to use as they wish. This wording should probably be refined by lawyers. 3. Yes, we think it will still make sense to have some features limited to registered users. 4. There is no source taken from code assist. SnipMatch simply performs code assist invisibly on a dummy document, and uses the results. 5. Yes, that is correct. (In reply to comment #9) > Doug, Zi (probably Zi), can you answer Sharon's questions below to solve the > last issues before the contribution get's accepted? > > ------- Comment #8 From Sharon Corbett 2012-01-23 16:50:40 [reply] ------- > Hi Marcel: > > I've completed the initial triage and I'll need your help to understand the > following: > > 1. SnippetMatchEnvironment.java and MatchEnvironment.java include the > following comment, "must be implemented by derived classes". I'd like your > help to understand this comment. > > 2. SubmitBox.java includes the following, "By checking the box above, you > confirm that you have full rights to release the code in this snippet, and > agree to release it to the public domain. You also understand that > "Language Interfaces is not responsible for any misuse of this code". I'd > like your help to understand this comment. > > 3. SnipMatchPlugin.java contains, "this feature is only available for > registered users". Is this no longer applicable? > > 4. JavaSnippetMatchEnvironment.java references the use of Code Assist. Is it > correct to understand there is no source contained from Code Assist? > > 5. Feature.xml contains copyright to SnipMatch as well as a license URL that > is not to the EPL. I'm guessing both items are no longer applicable? > > > Thanks for your time. > > Kind Regards, > Sharon Snipmatch has been added: http://git.eclipse.org/c/recommenders/org.eclipse.recommenders.git/commit/?id=761306d5611955def064c21b791448a8c7c6fbe5 Hip hip... Set target milestone for fixed bugs to 1.0 Set target milestone for fixed bugs to 1.0 |