Bug 365010

Description Mohsen Vakilian 2011-11-28 16:59:34 EST

Build Identifier: M20110909-1335

We developed a custom refactoring data collector for Eclipse called CodingSpectator <http://codingspectator.cs.illinois.edu/>. Eclipse records every performed refactoring in ".metadata/.plugins/org.eclipse.ltk.core.refactoring/.refactorings/.../refactorings.history". CodingSpectator augments the refactorings in "refactorings.history" with more data. However, we noticed that the Change Method Signature may get recorded incorrectly. For example, the log of a Change Method Signature refactoring does not show the change in the order of method parameters or the names of method parameters.

Reproducible: Always

Steps to Reproduce:
1. Consider the following source code.

----
//C.java
public class C {

	int m(int a, int b) {
		return a / b;
	}

	public static void main(String[] args) {
		System.out.println(new C().m(4, 2));
	}

}
----

2. If you use the Change Method Signature to reorder the parameters of C.m from "int a, int b" to "int b, int a", Eclipse will record the refactoring as the following in ".metadata/.plugins/org.eclipse.ltk.core.refactoring/.refactorings/.../refactorings.history".

----
<refactoring comment="Change method 'int C.m(int b, int a)' to 'int m(int b, int a)'
- Original project: 'P'
- Original element: 'C.m(...)'" delegate="false" deprecate="true" description="Change method 'm'" flags="589830" id="org.eclipse.jdt.ui.change.method.signature" input="/src<{C.java[C~m~I~I" name="m" parameter1="int b 1 int b false" parameter2="int a 0 int a false" stamp="1322513797840" version="1.0"/>
----

The problem is that the recorder refactoring descriptor doesn't indicate the change made to the method signature.

3. Similarly, if you use the Change Method Signature refactoring to rename the second parameter of the method C.m from "b" to "c", Eclipse will record the refactoring as the following in ".metadata/.plugins/org.eclipse.ltk.core.refactoring/.refactorings/.../refactorings.history".

----
<refactoring comment="Change method 'int C.m(int a, int c)' to 'int m(int a, int c)'
- Original project: 'P'
- Original element: 'C.m(...)'
- Changed parameters:
     int b" delegate="false" deprecate="true" description="Change method 'm'" flags="589830" id="org.eclipse.jdt.ui.change.method.signature" input="/src<{C.java[C~m~I~I" name="m" parameter1="int a 0 int a false" parameter2="int b 1 int c false" stamp="1322514484229" version="1.0"/>
----

Again, the problem is that the "comment" attribute in the above refactoring descriptor doesn't show the rename from "b" to "c". However, one might be able to infer the rename from the values of the two attributes "parameter1" and "parameter2".