Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 364997

Summary:

HTML code folding slows down typing in PHP files

Product:

z_Archived

Reporter:

Natalia Bartol <natalia.bartol>

Component:

PDT

Assignee:

PHP Core <php.core-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

jacek.pospychala, silviya

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
HTML folding in PHP files optimized - patch	jacek.pospychala: iplog+

Description Natalia Bartol

2011-11-28 14:09:44 EST

Build Identifier: 

Typing in big PHP files that contains PHP blocks mixed with HTML may become quite slow. Unchecking "Enable folding" in Structured Text Editor preferences helps with  this issue. May be related to Bug 323401.

Reproducible: Always

Comment 1 Natalia Bartol

2011-11-28 14:14:09 EST

Created attachment 207619 [details]
HTML folding in PHP files optimized - patch

Attached patch improves the way the annotation modifications are collected and applied. If annotation projection model change already exists for a node, the old change is removed and only the new one is stored. As a result there is less annotation modifications to apply (applying happens in UI thread and blocks editor).

Comment 2 Zhongwei Zhao

2011-12-01 06:05:20 EST

it is ok for me,committed.Thanks!

Comment 3 Sylvia Tancheva

2012-07-06 10:01:51 EDT

Closing
Ilina Stefanova