Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 364950

Summary:

Workbench is not mirrored correctly when using "nl" option

Product:

[Eclipse Project] Platform

Reporter:

Ghada Selim <ghadas>

Component:

Assignee:

Oleg Besedin <ob1.eclipse>

Status:

VERIFIED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

daniel_megert, dsayed, emoffatt, ghadas, kitlo, ob1.eclipse, pwebster, remy.suen

Version:

4.2

Target Milestone:

4.2 M7

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Testing Snapshots	none
Proposed patch	none
Screenshot	none

Description Ghada Selim

2011-11-28 08:29:01 EST

Build Identifier: 

Workbench is not mirrored correctly when using "nl" option with a bidi language pack installed.

Reproducible: Always

Steps to Reproduce:
1.Install Arabic pack.
2.open eclipse with option "-nl ar_eg"

Expected result:
The layout of eclipse workbench is mirrored.(Refer to bug 303889 for a full description for all the the RTL orientation cases against the usage of nl option)

Actual result:
The layout of eclipse workbench is in LTR mode while the internal windows like preference window is mirrored correctly.(See the attachment)

Comment 1 Ghada Selim

2011-11-28 08:30:34 EST

Created attachment 207600 [details]
Testing Snapshots

Comment 2 Ghada Selim

2011-11-28 08:33:47 EST

Created attachment 207602 [details]
Proposed patch

Please find a proposed fix for this bug

Comment 3 Oleg Besedin

2012-04-10 14:09:33 EDT

Thank you Ghada, I added changes to the Git master branch:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7c7397b74eb4af6690d787dd4be9596a2230e555

Comment 4 Oleg Besedin

2012-04-18 11:38:04 EDT

*** Bug 352656 has been marked as a duplicate of this bug. ***

Comment 5 Oleg Besedin

2012-05-01 14:12:40 EDT

Verified in I20120430-1800.

Comment 6 Curtis Windatt

2012-05-01 15:10:36 EDT

I cannot get the workbench to open mirrored.  Perhaps I am getting the steps incorrect.

1) Install the Arabic language pack from Babel
2) Start eclipse I20120410-0633 with -nl ar_eg

The workbench isn't mirrored, the arabic language pack is reasonably complete, so I end up with my workbench looking exactly like the LTR layout from the original picture.  Other dialogs including the preference page/about dialog all show RTL.

Comment 7 Oleg Besedin

2012-05-01 15:21:23 EDT

Created attachment 214890 [details]
Screenshot

(In reply to comment #6)
> I cannot get the workbench to open mirrored.  Perhaps I am getting the steps
> incorrect.

The attached screenshot is what I see.

> 
> 1) Install the Arabic language pack from Babel
> 2) Start eclipse I20120410-0633 with -nl ar_eg
> 

The "0410"? 

The only thing I can think of is that I put NL packs into drop-in folder.

Comment 8 Dani Megert

2012-05-02 03:09:06 EDT

I can confirm that it works using 4.2-I20120430-1800. It worked both ways: unzipping into the existing install or into 'dropins'.