Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 364935

Summary: Vaadin 6.5.3 breaks the edit dialog
Product: z_Archived Reporter: Michael Ochmann <michael.ochmann>
Component: SkalliAssignee: Michael Ochmann <michael.ochmann>
Status: RESOLVED FIXED QA Contact:
Severity: blocker    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
proposed patch none

Description Michael Ochmann CLA 2011-11-28 05:45:32 EST 
When switching to the new target platform skalli.target Vaadin 6.5.3 from the Eclipse Orbit is referenced now instead of Vaadin 6.4.0 in the old skalli-for-eclipse.target. 

However, with Vaadin 6.5.3 the edit dialog is not opened anymore if clicking on the "Edit" link in the navigation panel of a project's detail page. On creating a new project, the edit dialog works fine.
Comment 1 Michael Ochmann CLA 2011-11-28 05:48:10 EST 
Workaround:

For local development, comment the line

<unit id="com.vaadin" version="6.5.3.v201111241034"/>

in skalli.target and work with a filesystem location

<location path="${project_loc:org.eclipse.skalli.target}/target-platform-3rdparty" type="Directory">
<unit id="com.vaadin" version="6.4.0"/>
</location>

as in skalli-for-eclipse.target before.
Comment 2 Michael Ochmann CLA 2011-11-28 05:55:09 EST 
o.e.s.view/search/project.jsp line 74:

Some preliminary debugging shows, that Vaadin seems to no longer handle the pathInfo parameter in

vaadin.vaadinConfigurations["project"] = {appUri:'/vprojects', pathInfo: '<%=pathInfo%>', windowName: '<%=windowName%>', themeUri:'/VAADIN/themes/simple', versionInfo : {vaadinVersion:"6.5.3",applicationVersion:"NONVERSIONED"},"comErrMsg": {"caption":"Communication problem","message" : "Take note of any unsaved data, and <u>click here</u> to continue.","url" : null}};

It does not matter what you send, ProjectApplication#onRequestStart() always receives "UIDL". However, pathInfo has been used by us to transport the project name and the edit" keyword that triggers the edit dialog.

Putting everythibng into the appUri parameter seems to work, but not sure yet whether that is the "correct" way.
Comment 3 Michael Ochmann CLA 2011-11-29 05:21:23 EST 
com.vaadin.terminal.gwt.client.ApplicationConfiguration:

pathInfo parameter has been removed completely from ApplicationConfiguration in 6.5.3 explaining why setting pathInfo in project.jsp no longer works
Comment 5 Michael Ochmann CLA 2011-11-30 04:12:09 EST 
Created attachment 207710 [details]
proposed patch