Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 364933

Summary:	'Delete Tag...' should be 'Delete Tag'
Product:	[Technology] EGit	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Kevin Sawicki <kevin>
Status:	VERIFIED FIXED	QA Contact:
Severity:	trivial
Priority:	P3	CC:	matthias.sohn, remy.suen
Version:	1.2
Target Milestone:	1.2
Hardware:	All
OS:	All
Whiteboard:

Description Dani Megert

2011-11-28 05:15:49 EST

Comment 1 Dani Megert

2011-11-28 05:18:50 EST

1.2.0.201111201913.

The new 'Delete Tag...' action should not have "...". This is only added when additional user input/selection is required to complete the action.

Comment 2 Kevin Sawicki

2011-11-28 12:40:17 EST

So '...' shouldn't be used when showing a confirmation dialog?

Comment 3 Dani Megert

2011-11-29 01:59:32 EST

(In reply to comment #2)
> So '...' shouldn't be used when showing a confirmation dialog?

Exactly. Only when the user is requested for additional input to actually run the action one uses the "...".

Comment 4 Kevin Sawicki

2011-11-29 12:12:24 EST

Thanks Dani for the clarification

Comment 5 Kevin Sawicki

2011-11-29 18:35:19 EST

Proposed fix pushed to: http://egit.eclipse.org/r/4697

Comment 6 Matthias Sohn

2011-11-29 18:55:40 EST

merged as 1da78ce7306b4d2f1ffcfc79b3cc15eabd277b60

Comment 7 Dani Megert

2011-12-06 06:22:04 EST

Verified in 1.2.0.201112051848.