| Summary: | Space with dash in path with --exec option will cause VM to fail to start | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [RT] Jetty | Reporter: | Éric Daigneault <eric.daigneault> | ||||
| Component: | server | Assignee: | Thomas Becker <tbecker> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | janb, jesse.mcconnell, jetty-inbox, simone.bordet, tbecker | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 7.5.x | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| See Also: | https://bugs.eclipse.org/bugs/show_bug.cgi?id=369349 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Éric Daigneault
It can be fixed by tokenizing the commandline options in Main.java into a String[] and calling Runtime.exec(String[], ...) instead of Runtime.exec(String,...). The latter tokenizes by spaces and that's why the CMDL breaks. However having spaces and dashes combined in a directory path is a very bad idea and can have other side effects as well. So I'd just say we don't support spaces+dashes in directory names. marking enhancement, a patch will make it get reviewed and implemented faster, otherwise we'll add it to the 'todo' list I haven't looked at the code (yet) as I need to urgently find out why --exec is not working properly anymore. But just not to forget it, I'd like to check if this change by Joakim probably fixed this as well: commit 3df95d45c27c924c1f0e76c4c16a3f796ddf2470 Author: Joakim Erdfelt <joakim.erdfelt@gmail.com> 2012-01-20 19:27:38 Committer: Joakim Erdfelt <joakim.erdfelt@gmail.com> 2012-01-20 19:27:38 Parent: 58c57a9ea0288acf80e52b85e35349811d88fb5a (367635: report errors) Child: bc5ac3622aa39b6e60b96ab24b0fb11c09535172 (369349 replace quotes with a space escape method) Branches: origin/central-orbit-repo, origin/master, master, origin/HEAD Created attachment 210361 [details]
proposed patch
fix for --dry-run attached
Comment on attachment 210361 [details]
proposed patch
attached to the wrong issue
Just tested it, this one is fixed together with the patch provided for: https://bugs.eclipse.org/bugs/show_bug.cgi?id=369349 --exec works fine in a directory called "jetty\ space\ \ -\ space/" Closing this as fixed/duplicate. Although https://bugs.eclipse.org/bugs/show_bug.cgi?id=369349 needs to be committed first. |