Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 364890

Summary:

BinaryTypeBinding should use char constants from Util

Product:

[Eclipse Project] JDT

Reporter:

Stephan Herrmann <stephan.herrmann>

Component:

Core

Assignee:

Stephan Herrmann <stephan.herrmann>

Status:

VERIFIED FIXED

QA Contact:

Severity:

trivial

Priority:

CC:

amj87.iitr

Version:

3.8

Target Milestone:

3.8 M5

Hardware:

Other

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
proposed changes	none

Description Stephan Herrmann

2011-11-26 10:36:11 EST

(In reply to bug 186342 comment #150)
> (In reply to bug 186342 comment #146)
> > 1) In
> > org.eclipse.jdt.internal.compiler.lookup.BinaryTypeBinding.scanMethodForNullAnnotation(IBinaryMethod,
> > MethodBinding) and scanTypeForNullAnnotation(..), the constant
> > org.eclipse.jdt.core.Signature.C_RESOLVED should be used instead of character
> > 'L'.
> 
> Even better: org.eclipse.jdt.internal.compiler.util.Util since
> org.eclipse.jdt.core.Signature isn't available for ecj :)
> While we're at it: should I make the same change also for other occurrences
> of 'L' within BinaryTypeBinding?

It turns out, BinaryTypeBinding could use the constants from class Util
in quite a few places.

Comment 1 Stephan Herrmann

2011-11-26 10:40:14 EST

Created attachment 207566 [details]
proposed changes

Comment 2 Stephan Herrmann

2011-12-22 09:37:45 EST

Released for 3.8 M5 via commit 6e5a548d86606bf19201f8e25ff7972af2431caf

Comment 3 Ayushman Jain

2012-01-23 09:45:39 EST

Verified for 3.8M5 using code inspection