Bugzilla – Full Text Bug Listing
| Summary: | feature not correctly built when multiple arch filters are specified | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Steffen Pingel <steffen.pingel> | ||||
| Component: | Tycho | Assignee: | Jan Sievers <jan.sievers> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | minor | ||||||
| Priority: | P3 | CC: | artem.kovalev, jan.sievers, shawn.minto | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: |
https://git.eclipse.org/r/86565 https://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=0c36eae3b342d9eb33e653f266173c0c3c5771d7 |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | 351056 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Created attachment 207543 [details]
example project
This caused the problem described at https://bugs.eclipse.org/bugs/show_bug.cgi?id=349351#c49. The expected bundle with the filter was simply not added to the site. What surprised me is that the build did not fail, neither when the feature was built nor when the repository was generated. IIRC the syntax with multiple values to os/ws/arch in the inclusion is invalid (see bug 343339 comment 4), so the problem is that the build does not fail. This probably needs to be fixed in p2, so we'll need the enhancement of p2 bug 351056. New Gerrit change created: https://git.eclipse.org/r/86565 New Gerrit change created: https://git.eclipse.org/r/86565 proposed patch looks promising as it supposedly also fixes bug 392357 (In reply to Jan Sievers from comment #6) > proposed patch looks promising as it supposedly also fixes bug 392357 I have added a minimal IT to the proposed change. bug 392357 turns out to be similar but different. It only concerns nl filters (as opposed to os/ws/arch here) and is not fixed by the proposed change Gerrit change https://git.eclipse.org/r/86565 was merged to [master]. Commit: http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=0c36eae3b342d9eb33e653f266173c0c3c5771d7 . |
Steps: 1. Build a feature that includes a bundle that has a filter: arch="x86,x86_64" The build produces a feature.xml that does not correctly include the plugin, e.g.: <plugin id="example-bundle" os="win32" ws="win32" arch="x86,x86_64" download-size="0" install-size="0" version="0.0.0" unpack="false"/> If I change the filter to arch="x86" the following feature is generated as expected: <plugin id="example-bundle" os="win32" ws="win32" arch="x86" download-size="57" install-size="110" version="0.1.0.201111251649" unpack="false"/> I am running the build on gtk/X86_64. I have attached a small sample project to reproduce the problem.