Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 364843

Summary: [Contributions] [Compatibility] missing tooltips on some actions in main toolbar
Product: [Eclipse Project] Platform Reporter: Nicolas Bros <nicolas.bros>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P5 CC: gdupe, Mike_Wilson, pwebster, remy.suen
Version: 4.2   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard: stalebug
Bug Depends on:    
Bug Blocks: 365316    
Attachments:
Description Flags
screenshot
none
test file none

Description Nicolas Bros CLA 2011-11-25 09:48:27 EST
I noticed that with Eclipse 4.2, there is no tooltip on some toolbar buttons.
Whereas the tooltip was displayed on Eclipse 3.7.

For example, the name defined on the command "org.eclipse.emf.facet.efacet.ui.createFacetInFacetSet" in this plug-in doesn't appear as a tooltip:
https://dev.eclipse.org/svnroot/modeling/org.eclipse.emft.facet/trunk/plugins/org.eclipse.emf.facet.efacet.ui/plugin.xml

Also, the (platform-contributed) "Run" and "Debug" toolbar buttons have no tooltip whereas they had in Eclipse 3.7.


Eclipse SDK
Version: 4.1.0
Build id: I20110916-1615
Comment 1 Remy Suen CLA 2011-11-25 15:01:00 EST
Nicolas, how can I get the tool item in question to show up in my Eclipse?
Comment 2 Nicolas Bros CLA 2011-11-26 04:24:10 EST
(In reply to comment #1)
> Nicolas, how can I get the tool item in question to show up in my Eclipse?

You can install EMF Facet from 
http://download.eclipse.org/facet/updates/nightly/
Comment 3 Remy Suen CLA 2011-11-26 07:13:14 EST
(In reply to comment #2)
> (In reply to comment #1)
> > Nicolas, how can I get the tool item in question to show up in my Eclipse?
> 
> You can install EMF Facet from 
> http://download.eclipse.org/facet/updates/nightly/

I installed it from the Juno update site (not the nightlies) but "nothing" happened. I didn't get new perspectives or anything. Was I doing something wrong?
Comment 4 Nicolas Bros CLA 2011-11-26 14:26:01 EST
Created attachment 207571 [details]
screenshot

Are the actions enabled in your perspective? Do you see them at all? (see attached screenshot)
Comment 5 Remy Suen CLA 2011-11-26 17:52:25 EST
(In reply to comment #4)
> Created attachment 207571 [details]
> screenshot
> 
> Are the actions enabled in your perspective? Do you see them at all? (see
> attached screenshot)

You currently cannot customize perspectives in 4.x so I can't bring that dialog up actually. Do I need to open some files or something? Are they for editors?
Comment 6 Nicolas Bros CLA 2011-11-27 06:27:32 EST
Created attachment 207580 [details]
test file

Sorry, I confused the Eclipse versions.

I discovered the problem when running one of EMF Facet's SWTBot test on Eclipse 4.2M2 :
https://dev.eclipse.org/svnroot/modeling/org.eclipse.emft.facet/trunk/tests/org.eclipse.emf.facet.query.java.ui.tests/src/org/eclipse/emf/facet/query/java/ui/tests/internal/FacetWizardsTests.java

The tests are supposed to find the toolbar buttons by their tooltip, but these tests fail because these toolbar buttons don't seem to have any tooltip.
Cf method "getToolbarButton" in SWTBotUtils:
https://dev.eclipse.org/svnroot/modeling/org.eclipse.emft.facet/trunk/plugins/org.eclipse.emf.facet.util.tests.swtbot/src/org/eclipse/emf/facet/util/tests/swtbot/internal/SWTBotUtils.java

The thing is, when I run the tests locally on my PC, I can see the toolbar buttons.
But I tried installing EMF Facet on a new Eclipse 4.2M3, and I (like you) don't see the toolbar buttons at all when I open the EFacet editor.

I am still running the tests on an Eclipse 4.2M2, so maybe that's the difference. Or maybe that's because the tests open the editor programmatically (using IDE#openEditor(page, iFile, editorId)), whereas I open it manually.

I will continue to investigate later.


I was going to suggest that you test instead with the "Run" and "Debug" toolbar buttons that are contributed by Platform, since the bug appeared with them too, but then I noticed that their tooltips now appear correctly with 4.2M3, whereas they didn't with 4.2M2.
Comment 7 Remy Suen CLA 2011-11-28 07:56:41 EST
(In reply to comment #6)
> I was going to suggest that you test instead with the "Run" and "Debug" toolbar
> buttons that are contributed by Platform, since the bug appeared with them too,
> but then I noticed that their tooltips now appear correctly with 4.2M3, whereas
> they didn't with 4.2M2.

Those probably won't show properly. See bug 317182.
Comment 8 Remy Suen CLA 2011-11-28 09:29:06 EST
I don't see toolbar buttons when I open your efacet file in 3.x or in 4.x. I installed the EMF Facet SDK from the Juno update site.

EMF Facet SDK (Incubation)
0.2.0.v201111081641
org.eclipse.emf.facet.sdk.feature.feature.group	Eclipse Modeling Project
Comment 9 Mike Wilson CLA 2012-04-17 15:07:57 EDT
lowering prio just while we're triaging...
Comment 10 Paul Webster CLA 2012-04-18 08:38:45 EDT
This should be re-tested, as the toolbar is managed differently post-M6

PW
Comment 11 Paul Webster CLA 2012-04-25 18:01:14 EDT
Nicolas, I've installed   EMF Facet SDK (Incubation)	0.2.0.v201203201014 (Juno M6)	into 4.2 I20120425-1200

I've opened the testUI.efacet file (imported into a regular project) in the Facet editor.

I don't see the toolbar at all.  Is there something else I need to do?

PW
Comment 12 Eclipse Genie CLA 2020-03-06 16:21:01 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.