Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 364739

Summary:

[Table] Client area shifts to the top when editing a cell on the bottom-most row

Product:

[RT] RAP

Reporter:

Rüdiger Herrmann <ruediger.herrmann>

Component:

RWT

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

unspecified

Target Milestone:

1.5 M4

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Project to reproduce the bug	none
Screenshot	none
Proposed patch	none

Description Rüdiger Herrmann

2011-11-24 12:11:38 EST

When activating a cell editor on a half-visible bottom-most row, the row is shifted up by one row but the editor stays on the former psoition.
Follow these steps to reproduce:
1. Import project from the attached zip
2. Run TableEntryPoint as RWT application
3. Resize the Shell so that the botom-most row is only partially visible
4. Click into the Description cell to edit it
-> you will see something like the attached screenshot. Note that the whole client-area of the table is shifted to the top to make room for a whole row to fit in.
Though I cannot see a real difference, the same use case works in the controls demo.

Comment 1 Rüdiger Herrmann

2011-11-24 12:14:19 EST

Created attachment 207492 [details]
Project to reproduce the bug

Comment 2 Rüdiger Herrmann

2011-11-24 12:15:00 EST

Created attachment 207493 [details]
Screenshot

Comment 3 Rüdiger Herrmann

2011-11-24 12:26:01 EST

The problem is reproducible in all browsers.

Comment 4 Ivan Furnadjiev

2011-11-25 03:35:30 EST

With the Tree/Table merge the fix for bug 279460 disappeared. Reintroducing the:
qx.ui.core.Widget.disableScrolling( this );
at the end of the Tree.js#construct seems to solve the problem. There is an annoying flickering (scroll up/down for a moment) when you click on a half-visible item, but that's how the fix works - listen for DOM scroll event end reset the scroll position to zero if scroll event occur.

Comment 5 Ivan Furnadjiev

2011-11-25 03:41:30 EST

Created attachment 207518 [details]
Proposed patch

Patch for the outlined solution in comment#4.

Comment 6 Rüdiger Herrmann

2011-11-28 13:20:21 EST

Just for the record: this is a regression of bug 279460.
Applied patch to v15_Tree_Table_Merge branch

Comment 7 Rüdiger Herrmann

2011-11-28 13:34:12 EST

(In reply to comment #6)
> Just for the record: this is a regression of bug 279460.
> Applied patch to v15_Tree_Table_Merge branch
The correct name of the branch is v14_Tree_Table_Merge

Also applied patch to CVS HEAD.