Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 364656

Summary:

SapphireDiagramEditor should not mark editor dirty when handling node update event. Model changes on the node will trigger that

Product:

z_Archived

Reporter:

Shenxue Zhou <shenxue.zhou>

Component:

Sapphire

Assignee:

Shenxue Zhou <shenxue.zhou>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

konstantin, raj.alagumalai

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
don't mark editor dirty on node update event.	none

Description Shenxue Zhou

2011-11-23 16:58:28 EST

Comment 1 Konstantin Komissarchik

2011-11-23 17:04:17 EST

Please attach a patch for review before committing since we are now in the shutdown phase.

Comment 2 Shenxue Zhou

2011-11-23 17:07:14 EST

It's actually not a derived property issue. When node update event reaches SapphireDiagramEditor, it doesn't need to explicitly mark the editor dirty. If model change happens, it'll mark the editor dirty.

Comment 3 Shenxue Zhou

2011-11-23 17:09:57 EST

Created attachment 207449 [details]
don't mark editor dirty on node update event.

Comment 4 Konstantin Komissarchik

2011-11-23 17:15:34 EST

Ok. Go ahead.

Comment 5 Shenxue Zhou

2011-11-23 17:21:44 EST

Patch submitted.

Comment 6 Konstantin Komissarchik

2011-11-23 18:00:25 EST

Did you commit this to 0.4.x branch? If you put this only in HEAD, it will not be in the 0.4 release.

Comment 7 Shenxue Zhou

2011-11-23 18:05:57 EST

(In reply to comment #6)
> Did you commit this to 0.4.x branch? If you put this only in HEAD, it will not
> be in the 0.4 release.

I just resubmitted it to 0.4.x branch. Good catch. Thanks!

Comment 8 Raj Alagumalai

2011-11-28 14:17:21 EST

verified with 0.4.0.201111231805

Comment 9 Konstantin Komissarchik

2011-11-28 14:22:16 EST

Closing.