Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 364644

Summary:	Reports shall exclude disabled review items / anomalies
Product:	z_Archived	Reporter:	Alvaro Sanchez-Leon <alvaro.sanchez-leon>
Component:	Mylyn	Assignee:	Jacques Bouthillier <lmcbout>
Status:	CLOSED MOVED	QA Contact:
Severity:	normal
Priority:	P3	CC:	fchouinard, lmcbout, sebastien.dubois
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows Vista
Whiteboard:
Bug Depends on:
Bug Blocks:	399541

Description Alvaro Sanchez-Leon

2011-11-23 14:42:45 EST

Today, review reports are generated considering every element as valid, 
However if a review element is disabled e.g. a Review Item Commit, all the line ranges involved shall not be considered for the total amount of lines under review, this values shall be excluded.

The same with the number of anomalies. Disabled anomalies shall be excluded.

Comment 1 Jacques Bouthillier

2012-01-17 08:46:50 EST

Evaluation:
Solution one
Filter the disable elements when transforming  the model for the report
    - Need ~ 1 day to test if feasible or not
    - Review: 1 day
    - This will eliminate any modification done at the BIRT report template since the data would be filtered out
Total 2 days

Solution 2
Modification at the BIRT report level

Time line:    
    - Define template for BIRT with new flag (R4EParticipant, ReviewItems and Review Anomalies) 
    - Adjust Data set for calculation     2 days
    - Adjust affected fields  (In review items, review anomalies and Participant)  2 days
    - Testing    1 day
    - Review    1 day
Total 6 days 

1- Need to define a new template which include the following field: enabled="false"
2- Structure affected: R4EAnomaly    
                                R4EItem
                                R4EParticipant

3- Need to create new DataSet to compute the following:
    R4EParticipant
    
    Review Items:
    - LOC
    - LOC / participant
    - Preparation Review Rate
    - Decision Review Rate

    Review Anomalies:
    - Defect Density

Comment 2 Alvaro Sanchez-Leon

2012-02-21 15:22:29 EST

*** Bug 368194 has been marked as a duplicate of this bug. ***

Comment 3 Jacques Bouthillier

2012-06-05 09:39:37 EDT

Note: When testing the disable element, the field is "isEnabled()" 
 The field description comes from the review.frame.core model, ReviewComponent

Comment 4 Sebastien Dubois

2013-01-24 16:54:10 EST

Jacques is his still an issue?

Comment 5 Jacques Bouthillier

2013-01-31 11:01:47 EST

Still an issue on R4E 0.12

Comment 6 Eclipse Webmaster

2022-11-15 11:45:08 EST

Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn