Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 364642

Summary:	ctrl+O toggle outline not working in navigator.
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	kdevolder
Version:	0.3
Target Milestone:	0.4 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2011-11-23 14:37:13 EST

ctrl+O is supposed to toggle the splitter area in the editor and navigator.  It works in the editor but not the navigator. In the navigator the dijit.byId is failing to find the split area.

Comment 1 Susan McCourt

2011-11-23 14:47:27 EST

fixed with ded7d872c5441546221f2cceccbe31c9d62dc31d

This broke long ago, when we switched from doing the dojo parsing on load to doing it at the very end.  So the 
dijit.byId
was failing because the dijits hadn't been added yet.

Comment 2 Kris De Volder

2012-01-24 16:22:38 EST

Still not working for me in the navigator view. I'm using the version of the client as pulled from git this morning.

It does work in the editor.

I tried in both firefox 9 and google chroom, both on linux.

It is failing here
			callback: function() {
				var splitArea = 
                                   dijit.byId("orion.innerNavigator");
				splitArea.toggle();}

Stacktrace:
dojo.addOnLoad.mBootstrap.startup.then.mCommands.Command.callback() at table.js:73
CommandService._processKey() at commands.js:195
dojo.hitch() at lang.js:130

So I guess it didn't find the dijit.byId("orion.innerNavigator")

Comment 3 Susan McCourt

2012-01-26 22:01:58 EST

I probably broke this when I restructured all the HTML pages.  The split area nesting changed and I may not have caught this case.

Comment 4 Susan McCourt

2012-01-30 13:22:37 EST

fixed.  once more.  with feeling.