Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 364594

Summary:	R4Eclipse needs protection against wrong preferences selection
Product:	z_Archived	Reporter:	Jacques Bouthillier <lmcbout>
Component:	Mylyn	Assignee:	Sebastien Dubois <sebastien.dubois>
Status:	RESOLVED INVALID	QA Contact:
Severity:	normal
Priority:	P3	CC:	alvaro.sanchez-leon, lmcbout
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows Vista
Whiteboard:

Description Jacques Bouthillier

2011-11-23 09:21:46 EST

When modifying the preferences, if by mistake a user add a "Rule Set" inside the group preference, it generates the following "NULL pointer" exception:

java.lang.NullPointerException
	at org.eclipse.mylyn.reviews.r4e.core.model.serial.impl.RModelFactoryExtImpl.loadUsrReviews(RModelFactoryExtImpl.java:177)
	at org.eclipse.mylyn.reviews.r4e.core.model.serial.impl.RModelFactoryExtImpl.openR4EReviewGroup(RModelFactoryExtImpl.java:146)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.model.R4EUIModelController.loadReviewGroups(R4EUIModelController.java:319)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.navigator.ReviewNavigatorView.preferenceChange(ReviewNavigatorView.java:675)
	at org.eclipse.core.internal.preferences.EclipsePreferences$2.run(EclipsePreferences.java:754)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.core.internal.preferences.EclipsePreferences.firePreferenceEvent(EclipsePreferences.java:757)
	at org.eclipse.core.internal.preferences.EclipsePreferences.put(EclipsePreferences.java:770)
	at org.eclipse.ui.preferences.ScopedPreferenceStore.setValue(ScopedPreferenceStore.java:789)
	at org.eclipse.jface.preference.ListEditor.doStore(ListEditor.java:250)
	at org.eclipse.jface.preference.FieldEditor.store(FieldEditor.java:680)
	at org.eclipse.jface.preference.FieldEditorPreferencePage.performOk(FieldEditorPreferencePage.java:343)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.preferences.R4EPreferencePage.performOk(R4EPreferencePage.java:732)
	at org.eclipse.jface.preference.PreferenceDialog$13.run(PreferenceDialog.java:964)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:49)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)
	at org.eclipse.jface.preference.PreferenceDialog.okPressed(PreferenceDialog.java:944)
	at org.eclipse.ui.internal.dialogs.FilteredPreferenceDialog.okPressed(FilteredPreferenceDialog.java:447)
	at org.eclipse.ui.internal.dialogs.WorkbenchPreferenceDialog.okPressed(WorkbenchPreferenceDialog.java:171)
	at org.eclipse.jface.preference.PreferenceDialog.buttonPressed(PreferenceDialog.java:233)

Comment 1 Jacques Bouthillier

2012-02-23 10:41:41 EST

Not reproducible