Bugzilla – Full Text Bug Listing
| Summary: | Proposed patch to be able to explicitly set pie slice colors | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] MAT | Reporter: | Kevin Grigorenko <kevin.grigorenko> | ||||
| Component: | GUI | Assignee: | Project Inbox <mat.gui-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | krum.tsvetkov | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Comment on attachment 207380 [details]
Proposed patch to be able to explicitly set pie slice colors
Thanks for the patch!
I reviewed and tested it. It looks fine.
I've submitted the changes as they are, only adjusted the copyright headers in the three files
As the patch is now applied (SVN revision 1277) I am closing the bug. Thanks again. Thanks! Kevin, the changes from the patch introduced an incompatible API change. I haven't noticed this on time, as I had my API tooling not configured after changing my IDE :( We'll need to make some changes to avoid this. You can watch bug 372002 for more details. (In reply to comment #4) > Kevin, the changes from the patch introduced an incompatible API change. I > haven't noticed this on time, as I had my API tooling not configured after > changing my IDE :( > We'll need to make some changes to avoid this. You can watch bug 372002 for > more details. Hey Krum, no worries at all. For my own knowledge, what caused the incompatibility? Was it because a method was added to IResultPie? (In reply to comment #5) > Was it because a method was added to IResultPie? Yes. It was the new method to the interface. There are some more details in bug bug 372002 BTW, I added some description how API tooling baseline can be setup for MAT: http://wiki.eclipse.org/MemoryAnalyzer/Contributor_Reference#Configure_API_Tooling_Baseline |
Created attachment 207380 [details] Proposed patch to be able to explicitly set pie slice colors