Bugzilla – Full Text Bug Listing
| Summary: | new icons for 0.4 | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Susan McCourt <susan> |
| Component: | Client | Assignee: | Susan McCourt <susan> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | john.arthorne, ken_walker, mamacdon, Szymon.Brandys, tomasz.zarna |
| Version: | 0.3 | ||
| Target Milestone: | 0.4 RC1 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
Susan McCourt
(In reply to comment #0) > We need icons for "OK" and "More Options" in the parameter slideout. Committed new icons in e5d3f6060d10c4681e6f3f56aca7f870c02c3882. Leaving this bug open because there will surely be more. Also need to regenerate the sprite once the icons have stabilized. (right now my sprite classes for the new icons are loading individual files) we might want an alternate drop down arrow for empty drop down buttons. (a gear?) Forgotten from 0.2: custom/lightweight checkbox styling custom tree twisties (but maybe with bug 366245 we wouldn't need it?) another thing: we are using the stroke/yellow style for all icons, but when you have the file/folder icons next to command icons, it's hard to tell which icons "do something" and which don't. Maybe we need a different color for model icons, or need to be more intentional about differentiating them with button borders, etc. (In reply to comment #4) > another thing: > we are using the stroke/yellow style for all icons, but when you have the > file/folder icons next to command icons, it's hard to tell which icons "do > something" and which don't. Maybe we need a different color for model icons, > or need to be more intentional about differentiating them with button borders, > etc. it's been suggested in bug 366245 that we don't need these icons, unless we wanted to allow content types to define an icon, and then this would be the default. In a tree view, we may not need a folder icon because it would have a twistie. In a non-tree view, we probably still want a folder icon. Mark, if you want to pursue the content type icon idea (in another bug), then I would want a list in this bug for the content types that we should have default icons for. And I think they would not be in the Orion yellow style, because they are different than our command/yellowy icons. We might be able to steal icons from eclipse. We need the "Git Pull" icon. So far we use the one created by Tomek. I put in some placeholder icons for a lighterweight checkbox and a larger (easier to hit) twistie. I don't use the folder icon at all in the nav (see bug 366258). I replaced the file icon with the old eclipse file icon, on the assumption that we want to move to using content type icons, and don't want the "Yellow stylized" icons for model icons. Summarizing the active list (this comment renders previous comments obsolete. New icons needed: checkbox checkbox checked git pull gear Revisit existing icons. Do we want a less obtrusive twistie? tree twistie open tree twistie closed tree twistie opening (for completeness, not used) Content type icons needed: HTML CSS JS JSON XML Java Image (in case we want to replace thumbnail with a hovering thumbnail) I'm currently using some silk icons for HTML, CSS, JS. They are kind of loud/not matching the rest of the style. Best would be to round up the Eclipse Java and JSDT icons for these. John, would we need a CQ to use JSDT icons in Orion? (In reply to comment #8) > John, would we need a CQ to use JSDT icons in Orion? No, but we would need to acknowledge them in our about.html because the license is different (EPL for JSDT vs EDL for Orion). If we could keep them in a separate folder that would make it easier to manage. I've pushed the model icons in c345a4ef81a44139f2ca44afb95c0f9a5811e327. Note that these are technically "WTP" icons not "JSDT" since JSDT is a subproject of WTP, and the HTML, CSS icons are from other parts of WTP. (In reply to comment #9) > (In reply to comment #8) > > John, would we need a CQ to use JSDT icons in Orion? > > No, but we would need to acknowledge them in our about.html because the license > is different (EPL for JSDT vs EDL for Orion). If we could keep them in a > separate folder that would make it easier to manage. I put the icons in a subfolder images/wtp I checked the about.html in org.eclipse.orion.client.core and it already refers to both EPL and EDL: Unless otherwise indicated below, the Content is provided to you under the terms and conditions of the Eclipse Public License Version 1.0 ("EPL"), and the Eclipse Distribution License Version 1.0 ("EDL"). For purposes of the EPL and EDL, "Program" will mean the Content. (In reply to comment #10) > I checked the about.html in org.eclipse.orion.client.core and it already refers > to both EPL and EDL: > > Unless otherwise indicated below, the Content is provided to you under the > terms and conditions of the Eclipse Public License Version 1.0 ("EPL"), and the > Eclipse Distribution License Version 1.0 ("EDL"). For purposes of the EPL and > EDL, "Program" will mean the Content. The difference is that Orion client is dual-licensed under *both* EDL and EPL. I don't think we can take something that was only EPL and redistribute under dual license. I'll take care of adding something to about.html about this. (In reply to comment #11) > The difference is that Orion client is dual-licensed under *both* EDL and EPL. > I don't think we can take something that was only EPL and redistribute under > dual license. I'll take care of adding something to about.html about this. thanks, John. should I open a bug? Susan, I would like to request icons for git repository page, however we do not reach agreement what deserves its own icon and what does not. Could you look at bug 359621 and let me know where you would use icons? *** Bug 361109 has been marked as a duplicate of this bug. *** I am making some icons for progress service. I don't know yet how many of the will be needed, I suppose it will clarify soon. I'm kindly requesting new icons for Save (bug 365576) and Apply (bug 365575) Patch actions. per a review with Linda (see bug 360986 comment 15)...here is the cumulative list of new icons: - checkbox - checkbox checked - twistie open - twistie closed - twistie opening... - menu icon (not a gear. there is an IBM menu icon that she suggests that we can get released for eclipse) - git pull - git status - git log - git remote - apply patch - cherry pick (see https://bugs.eclipse.org/bugs/attachment.cgi?id=205487) Note that some of these icons (git remote) may only ever be used in a menu but I'm getting them for completeness. Once we have the icons we can do another menu organization pass. It is best, for example, if the same 3-4 icons are used as iconic commands on the various git pages vs. the user having to remember a bunch of a different ones, with the remaining commands appearing in menus with descriptive text. (In reply to comment #16) > I'm kindly requesting new icons for Save (bug 365576) and Apply (bug 365575) > Patch actions. We mid-air collided on this bug so I didn't have Save on the list. Is this an icon that should specifically indicate "save a diff"? (In reply to comment #13) > Susan, I would like to request icons for git repository page, however we do not > reach agreement what deserves its own icon and what does not. Could you look at > bug 359621 and let me know where you would use icons? There is some discussion about this in bug 360986 comment 15. The three new icons implied by that mockup are - reset - rebase - commit I can request these so that we have them available. However if we were to replace each of those text buttons with an icon, I think it would be a lot for the user to figure out, and I think that "reset" and "rebase" require thought because they are potentially destructive to your state (reset) or put you in a state you might not understand (rebase). Plus they really aren't used all that often. So we might want to put these in menus next to the main buttons. But from the point of view of icons, I think we should get them all so we can change our mind as the UI evolves. new cumulative list: - git pull - git status - git log - git remote - apply patch - cherry pick (see https://bugs.eclipse.org/bugs/attachment.cgi?id=205487) - save (diff? needs explanation) - reset - rebase - commit - menu icon (not a gear. there is an IBM menu icon that she suggests that we can get released for eclipse) - checkbox - checkbox checked - twistie open - twistie closed - twistie opening... I've submitted requests for these icons in three batches. I also committed placeholder icons for git status, git log, cherry pick, apply patch, and the menu icon, so we can see if the idea of using all icons really works. (not sure that it does). Git Icons (internal request #8200) > - git pull > - git status > - git log > - git remote > - apply patch > - cherry pick (see https://bugs.eclipse.org/bugs/attachment.cgi?id=205487) > - save (diff? needs explanation) > - reset > - rebase > - commit Menu icon (8198, submitted separately to get quick turn around since icon already exists. Added a placeholder for now) > - menu icon Navigator icons (8199) > - checkbox > - checkbox checked > - twistie open > - twistie closed > - twistie opening... I could not describe in any way that made sense a "rebase" and "reset" icon. Further, these are well known terms in git. I did not request icons for these. will put new icons in after M2 just pushed new checkbox, twistie icons. For icons that appear in banners and toolbars (for status, or common links, or navigating a list), we are going to move away from yellow. We'll use yellow icons inside resource content for model icons and icon commands. That means we need some rework on some of our existing icons (toolbar slideouts, etc.) So here's a working list of the icons needing rework: - help (the help icon in the banner should not be yellow. Also under discussion is whether we want a dedicated icon or want to put it in the user menu). - close (X). For the slideout and for closing the notification messages that appear in the slideout. Not yellow. - OK/Submit (check mark). For the slideout. Not yellow. - More (...) for the slideout. Not yellow. - Favorite icon in banner?? Not yellow??? - Navigation arrows - up, down, left, right. These arrows might be used in toolbars when an arrow makes more sense than words (next search result, etc.). Need non yellow versions. - Operations running animated icon (we are currently using the eclipse one, might be good enough) - Operations none. A button to open the current operations list when none are running. - Operation ended in error. - Operation ended in warning. pushed new git icons. So we are now caught up except for new icons in comment 25. this bug is getting hard to track. Since the original requests were completed, I am going to close this and now we can have bugs for specific additions. bug 370478 - git rebase and reset. I'd like to have something in our back pocket given we are trying to do all icons in the row-level actions. bug 370481 - specialized icons for toolbars and slideouts |