Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 364086

Summary: EJB Project wizard doesn't show up and shows an error
Product: [WebTools] WTP Java EE Tools Reporter: Galileo Perez <galileo>
Component: jst.j2eeAssignee: Galileo Perez <galileo>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: normal    
Priority: P3 CC: ccc, shr31223
Version: 3.3.1Flags: cbridgha: review+
Target Milestone: 3.3.1 P   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
Solves the problem about EJB Wizard not showing up because a NPE
none
resolves the NPe problem
none
Patch to fix the NPE when creating EJB project with no EAR existent
ccc: iplog+
Prevents NPE when creating EJB Project
none
Galileo's patch, rebased on R3_3_1_patches none

Description Galileo Perez CLA 2011-11-17 16:26:42 EST 
Build Identifier: Eclipse 3.7.1

Using an adopter product over eclipse 3.7.1 and WTP when creating an EJB project on a workspace with two runtimes, one supports a facet and the other doesn't. The wizard never appears and log. file shows a NPE.

java.lang.NullPointerException
	at org.eclipse.wst.common.project.facet.core.internal.FacetedProjectWorkingCopy.setProjectFacets(FacetedProjectWorkingCopy.java:726)
	at org.eclipse.wst.web.ui.internal.wizards.NewProjectDataModelFacetWizard.setRuntimeAndDefaultFacets(NewProjectDataModelFacetWizard.java:261)
	at org.eclipse.wst.web.ui.internal.wizards.NewProjectDataModelFacetWizard.createPageControls(NewProjectDataModelFacetWizard.java:150)
	at org.eclipse.jface.wizard.WizardDialog.createPageControls(WizardDialog.java:736)
	at org.eclipse.jface.wizard.WizardDialog.createContents(WizardDialog.java:608)
	at org.eclipse.jface.window.Window.create(Window.java:431)
	at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1089)



Reproducible: Always

Steps to Reproduce:
1.Install the two runtimes with EJB facet that is not supported in one of them
2.Create a web project with runtime of the runtime that does not support the EJB facet and check the Add project to EAR checkbox
3.File > New > EJB Project
Comment 1 Galileo Perez CLA 2011-11-17 17:01:36 EST 
Created attachment 207187 [details]
Solves the problem about EJB Wizard not showing up because a NPE

The patch verifies if a facet is valid in a runtime before to add the project as default EAR on the EJB creation wizard.
Comment 2 Galileo Perez CLA 2011-11-17 17:58:05 EST 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=364090 opened for eclipse 3.6.2 , wtp 3.2.5
Comment 3 Galileo Perez CLA 2011-11-17 18:14:48 EST 
Created attachment 207190 [details]
resolves the NPe problem
Comment 4 Galileo Perez CLA 2011-11-28 16:29:09 EST 
Created attachment 207627 [details]
Patch to fix the NPE when creating EJB project with no EAR existent

The difference from last one is a case not considered previously.
, and fixed on this patch
Comment 5 Chuck Bridgham CLA 2011-11-28 20:38:43 EST 
approved
Comment 6 Galileo Perez CLA 2011-11-30 12:59:57 EST 
Created attachment 207748 [details]
Prevents NPE when creating EJB Project

Patch to fix the NPE when creating EJB project with no EAR existent, problems no external code was modified as last patch does.
Comment 7 Carl Anderson CLA 2011-11-30 15:24:04 EST 
Created attachment 207758 [details]
Galileo's patch, rebased on R3_3_1_patches
Comment 8 Carl Anderson CLA 2011-12-01 15:56:59 EST 
Committed to R3_3_1_patches